G35 assisted tramming improvements

[qwewer0]

Description

• Adding ASSISTED_TRAMMING_WAIT_POSITION to G35.
  This already existed, but worked only with the tramming wizard and not the G35 command.

• Removing ASSISTED_TRAMMING_MENU_ITEM.
  (G35 assisted tramming improvements #20298 (comment))
  This only ran G35, which provides no value without being able to see the serial output.
  Users wishing for an interactive experience should use the wizard option.

• Disables homing Z after the G35 comment
  There was no value in homing Z after executing G35, because at that point you have not yet adjusted the screws.
  Instead, simply invalidate Z, so that homing is required before next use.

Benefits

Easier screw adjustment after G35 is done, in particular for printers where the print head blocks screw access.

Related Issues

#20281

[sjasonsmith]

@qwewer0 & @swissnorp it seems you are still working through some issues? Please reply when you have things worked out and think this is ready to review.

[qwewer0]

@qwewer0 & @swissnorp it seems you are still working through some issues? Please reply when you have things worked out and think this is ready to review.

@sjasonsmith I think this is ready for review.
I tested it and it is working as intended.

[sjasonsmith]

Sorry, this got a little lost in the pile and I never came back to it. Unfortunately I've now posted other changes which will conflict with this!

At this point I would prefer to wait for #20572 to be merged, then I can come back and resolve any issues it causes with this PR.

[sjasonsmith]

I actually ran across this missing capability when I was testing that other PR. It was completely non-obvious in the config file that it applied only to the wizard!

[qwewer0]

On the latest Pronterface they fixed the issue (kliment/Printrun#1103) with Clockwise, Counter-Clockwise not showing up correctly. Should we change it back or leave it as it is right now?
(d02d7a9)

[sjasonsmith]

Should we change it back or leave it as it is right now?

I don't know, but I don't think this change should be dependent on that.

[sjasonsmith]

I took the liberty of updating the title/description to make the reasoning for the changes apparent at a glance.

I think these are great changes. These items were all confusing while I was working on the code to validate the selected tramming points at build-time.

Aside from making G35 more useful, I think they will also help reduce some new-user confusion.

[sjasonsmith]

@qwewer0 could you add a sanity check for the removed option?

[qwewer0]

@qwewer0 could you add a sanity check for the removed option?

Done, could you check it, please?

[qwewer0]

@thinkyhead Thanks for the cleanup, looks good and logical. 👍

[o5]

Cannot build after rebase with this change :/

Compiling .pio/build/STM32F103RC_btt_USB/src/src/gcode/bedlevel/abl/M421.cpp.o
In file included from Marlin/src/feature/tramming.cpp:27:0:
Marlin/src/feature/tramming.h:36:36: error: static assertion failed: TRAMMING_POINT_XY point 0 is not reachable with the default NOZZLE_TO_PROBE offset and PROBING_MARGIN.
 #define VALIDATE_TRAMMING_POINT(N) static_assert(N >= G35_PROBE_COUNT || Probe::build_time::can_reach(screws_tilt_adjust_pos[N]), \
                                    ^
Marlin/src/feature/tramming.h:38:1: note: in expansion of macro 'VALIDATE_TRAMMING_POINT'
 VALIDATE_TRAMMING_POINT(0); VALIDATE_TRAMMING_POINT(1); VALIDATE_TRAMMING_POINT(2); VALIDATE_TRAMMING_POINT(3); VALIDATE_TRAMMING_POINT(4);
 ^~~~~~~~~~~~~~~~~~~~~~~
Marlin/src/feature/tramming.h:36:36: error: static assertion failed: TRAMMING_POINT_XY point 3 is not reachable with the default NOZZLE_TO_PROBE offset and PROBING_MARGIN.
 #define VALIDATE_TRAMMING_POINT(N) static_assert(N >= G35_PROBE_COUNT || Probe::build_time::can_reach(screws_tilt_adjust_pos[N]), \
                                    ^
Marlin/src/feature/tramming.h:38:85: note: in expansion of macro 'VALIDATE_TRAMMING_POINT'
 VALIDATE_TRAMMING_POINT(0); VALIDATE_TRAMMING_POINT(1); VALIDATE_TRAMMING_POINT(2); VALIDATE_TRAMMING_POINT(3); VALIDATE_TRAMMING_POINT(4);
                                                                                     ^~~~~~~~~~~~~~~~~~~~~~~
*** [.pio/build/STM32F103RC_btt_USB/src/src/feature/tramming.cpp.o] Error 1
In file included from Marlin/src/gcode/bedlevel/G35.cpp:43:0:
Marlin/src/gcode/bedlevel/../../feature/tramming.h:36:36: error: static assertion failed: TRAMMING_POINT_XY point 0 is not reachable with the default NOZZLE_TO_PROBE offset and PROBING_MARGIN.
 #define VALIDATE_TRAMMING_POINT(N) static_assert(N >= G35_PROBE_COUNT || Probe::build_time::can_reach(screws_tilt_adjust_pos[N]), \
                                    ^
Marlin/src/gcode/bedlevel/../../feature/tramming.h:38:1: note: in expansion of macro 'VALIDATE_TRAMMING_POINT'
 VALIDATE_TRAMMING_POINT(0); VALIDATE_TRAMMING_POINT(1); VALIDATE_TRAMMING_POINT(2); VALIDATE_TRAMMING_POINT(3); VALIDATE_TRAMMING_POINT(4);
 ^~~~~~~~~~~~~~~~~~~~~~~
Marlin/src/gcode/bedlevel/../../feature/tramming.h:36:36: error: static assertion failed: TRAMMING_POINT_XY point 3 is not reachable with the default NOZZLE_TO_PROBE offset and PROBING_MARGIN.
 #define VALIDATE_TRAMMING_POINT(N) static_assert(N >= G35_PROBE_COUNT || Probe::build_time::can_reach(screws_tilt_adjust_pos[N]), \
                                    ^
Marlin/src/gcode/bedlevel/../../feature/tramming.h:38:85: note: in expansion of macro 'VALIDATE_TRAMMING_POINT'
 VALIDATE_TRAMMING_POINT(0); VALIDATE_TRAMMING_POINT(1); VALIDATE_TRAMMING_POINT(2); VALIDATE_TRAMMING_POINT(3); VALIDATE_TRAMMING_POINT(4);

Unfortunately, I don't understand completely this feature so I'm not able to fix assertion. Could someone help me? There is my sources marlin, marlin-configurations.

[qwewer0]

@o5 #20572

[o5]

OK, I discovered that I enabled this option when reading some Reddit guide and (as most of others options... in that time, I promise!) and I didn't exactly know what I did :) So time to change it!

Looked into documentation and some explanation in youtube video but still cannot confidently answer my question: Is this calibration necessary for me if I'm using auto bed leveling with fixed probe before every print using G29? I think I should comment out ASSISTED_TRAMMING.

[qwewer0]

@o5 G35 can help you tram your bed. It is up to you if you want to use it or not, you can tram your bed with the paper method too.