-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect MANUAL_PROBE_START_Z in UBL #20160
Respect MANUAL_PROBE_START_Z in UBL #20160
Conversation
@Roxy-3D, do have any reason to NOT want UBL to respect |
I want to avoid merging this until I examing how it is related to #19804. It seems closely related to this, and maybe some additional adjustments are needed. |
Ironic that this fix for UBL, saving people their encoder wheels, for people using MBL it actually caused people to have to spin their encoder wheels more at every point! #facepalm #21239 |
Is it this which is having the unwanted effect? #if !defined(MANUAL_PROBE_START_Z) && defined(Z_CLEARANCE_BETWEEN_PROBES)
#define MANUAL_PROBE_START_Z Z_CLEARANCE_BETWEEN_PROBES
#endif And so, is it only problematic when |
Description
PROBE_MANUALLY
and UBL have a complex relationship. Enabling UBL implicitly disablesPROBE_MANUALLY
, because UBL has its own manual probing mechanism.Unfortunately this also causes the
MANUAL_PROBE_START_Z
to be ignored, since it wasn't originally added to UBL.This change modified UBL to use
MANUAL_PROBE_START_Z
, and falls back toZ_CLEARANCE_BETWEEN_PROBES
if it is available.Benefits
Allows users to reduce the amount of time they spend spinning their encoder wheels!
Configurations
The following configs are for use in the simulator. Real configs are available from the referenced issue.
Marlin.zip
Related Issues
#19795 - UBL with PROBE_MANUALLY doesn't lower to MANUAL_PROBE_START_Z and stays at Z_CLEARANCE_BETWEEN_PROBES