-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation errors for UI on Native build (simulator) #20092
Merged
thinkyhead
merged 6 commits into
MarlinFirmware:bugfix-2.0.x
from
rhapsodyv:color-ui-compilation-fix
Nov 11, 2020
Merged
Fix compilation errors for UI on Native build (simulator) #20092
thinkyhead
merged 6 commits into
MarlinFirmware:bugfix-2.0.x
from
rhapsodyv:color-ui-compilation-fix
Nov 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhapsodyv
changed the title
Fix compilation error for Color UI on Native build (simulator)
Fix compilation errors for UI on Native build (simulator)
Nov 10, 2020
ustsv
pushed a commit
to ustsv/Marlin
that referenced
this pull request
Nov 12, 2020
FhlostonParadise
pushed a commit
to FhlostonParadise/Marlin
that referenced
this pull request
Nov 21, 2020
Kannix2005
pushed a commit
to Kannix2005/Marlin-1
that referenced
this pull request
Dec 7, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 8, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 11, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TFT UI (color, classic and lvgl) fails to build on simulator because of the issues fixed here. Same are code that aren't used (but compiled), other a null pointer where it can't be.
ARM gcc just drops the unused references. But native don't. I prefer to fix it here, that just hiding the problem making native gcc drop it too.