Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IS_ULTIPANEL checks #19766

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix IS_ULTIPANEL checks #19766

merged 1 commit into from
Oct 16, 2020

Conversation

sjasonsmith
Copy link
Contributor

Description

The Prusa/MK3S-BigTreeTech-BTT002 failed to builds to to the following sanity check:

#if LCD_INFO_SCREEN_STYLE > 0
  #if HAS_MARLINUI_U8GLIB || LCD_WIDTH < 20 || LCD_HEIGHT < 4
    #error "Alternative LCD_INFO_SCREEN_STYLE requires 20x4 Character LCD."

This happened beacause width/height were not properly checking for IS_ULTIPANEL.

Benefits

Can compile when using REPRAP_DISCOUNT_SMART_CONTROLLER with #define LCD_INFO_SCREEN_STYLE 1.

Configurations

Prusa/MK3S-BigTreeTech-BTT002 example

Related Issues

N/A

@thinkyhead thinkyhead merged commit 050ba0e into MarlinFirmware:bugfix-2.0.x Oct 16, 2020
Zorchz pushed a commit to Zorchz/Marlin-1 that referenced this pull request Oct 17, 2020
@sjasonsmith
LCD conditionals followup (MarlinFirmware#19766)
a1d0935
Zorchz pushed a commit to Zorchz/Marlin-1 that referenced this pull request Oct 17, 2020
@sjasonsmith
LCD conditionals followup (MarlinFirmware#19766)
36f14a1
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Oct 21, 2020
@sjasonsmith @thinkyhead
LCD conditionals followup (MarlinFirmware#19766)
d074db4
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Oct 23, 2020
@sjasonsmith @Speaka
LCD conditionals followup (MarlinFirmware#19766)
6be2474
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Nov 2, 2020
@sjasonsmith @Speaka
LCD conditionals followup (MarlinFirmware#19766)
163055d
@sjasonsmith sjasonsmith deleted the PR/IS_ULTIPANEL branch November 23, 2020 09:32
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
@sjasonsmith @vgadreau
LCD conditionals followup (MarlinFirmware#19766)
27193f8
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
@sjasonsmith @tharts
LCD conditionals followup (MarlinFirmware#19766)
d2b70d3
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
@sjasonsmith @kpishere
LCD conditionals followup (MarlinFirmware#19766)
e73e6fd
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@sjasonsmith @W4tel-BiDi
LCD conditionals followup (MarlinFirmware#19766)
0cc141f
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
@sjasonsmith @thinkyhead
LCD conditionals followup (MarlinFirmware#19766)
3de49aa
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
@sjasonsmith @thinkyhead
LCD conditionals followup (MarlinFirmware#19766)
dd1bc55
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
@sjasonsmith @thinkyhead
LCD conditionals followup (#19766)
cedc5d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: LCD & Controllers PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjasonsmith @thinkyhead