Fix for mount not initialized SD card #19064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix 2.0.x
Bugfix 2.0.x
|
Marlin now errors out on boot without an SD card inserted. Is there a way to not display the error message on boot? |
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
|
@Serhiy-K / @thinkyhead: Can this be disabled on boot? I've seen users report this issue of "SD Init Fail" across several Facebook groups now when (intentionally) booting without an SD card inserted which is causing confusion. |
|
@Serhiy-K/@thinkyhead: I’m having the same issue too. Is there any fix for this. |
|
This is still an issue: #19226 (comment) SD card access/printing worked fine before this change on several different configs, but now users are presented with this false error on boot which doesn't make sense. Should this patch be reverted? |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have two test boards - based on LPC1768 and on STM32F401. My SD card 2GB works good with LPC, but with STM not - after inserting SD card LCD panel hangs up until I remove SD card. In my case problem located somewhere in low level STM library. I tried find this problem with step-by-step debugging and oscilloscope but I haven't found yet.
In any case, problem with init SD card may happen any time. So we don't need enter to cdroot() function after wrong SD init and need inform user about problem with his SD card.
Benefits
This fix excludes panel hang by bypassing cdroot() function after wrong SD init and informs user about problem with SD card on panel in status line.