Correct New Laser Inline Code #18237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 'trap_en' to 'enabled' and 'laser' to 'laser_trap' in Stepper.h Update instances of 'planner.laser_inline.status' to 'planner.laser_inline.status.isPlanned or isEnabled'
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Scott Lahteine <[email protected]>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Scott Lahteine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New laser code has compilation issues as pointed out by @gminadak : #17661 (comment)
Issue was
planner.laser_inline.statusnow needs to beplanner.laser_inline.status.isEnabledAlso
trap_enandlaserinStepper.hare nowenableandlaser_traprespectivelyplanner.laser_inline.status.isPlanned = trueis inplanner.cppinstead ofspindle_laser.hbecause the latter would not turn the laser off in between moves and at end of the job.