-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'extends' for STM32F1 #18099
Use 'extends' for STM32F1 #18099
Conversation
…dafruit dependency that breaks things.
Leave platform in each environment, to enable it to work properly in Visual Studio Code.
I am currently printing on an SKR Mini E3 1.0 built using these changes from inside VS Code. |
I've updated this to use a dynamic variable for the platform name, rather than redefining |
Unfortunately, last I checked with PlatformIO, the VSCode extension still doesn't know what to do with |
Just checked, and the PlatformIO extension still hasn't been updated since November. So we have to wait for that to happen before we can enjoy the benefits of |
@thinkyhead, it shows them as long as you define |
Oh, that's interesting. I wonder why that matters. |
Description
Utilize
extends
in PlatformIO to extract the commonalities between all STM32F1 environments.Visual Studio Code doesn't properly recognize environments if their
platform
is included as part of anextends
variable. For this reason I have leftplatform
in each environment even though PlatformIO does not require it.This PR overlaps with another PR of mine: #18089.
If this PR is merged then #18089 is not necessary.
Benefits
Allows STM32F1-specific changes to be made in one place and apply to all environments.
In this changelist, the only real change is reducing the version of the
Adafruit MAX31865 library
, since version 1.2 is incompatible with the STM32F1 HAL.Related Issues
#18081