Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix G76 reachable test #17005

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Fix G76 reachable test #17005

merged 2 commits into from
Feb 28, 2020

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Feb 27, 2020 •
edited
Loading

Addressing #16995

The position_is_reachable_by_probe function accounts for the probe offset, so we just need to pass the position without subtracting the offset.

Also: The G76 code needed to go on a diet. Much bloat has been removed.

@thinkyhead thinkyhead mentioned this pull request Feb 27, 2020
Merged
@thinkyhead thinkyhead mentioned this pull request Feb 27, 2020
Closed
@thinkyhead thinkyhead force-pushed the bf2_fix_g76_check_PR branch 4 times, most recently from 9f0ed6f to 1b3b049 Compare February 27, 2020 14:32
TheNeskik
TheNeskik suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@TheNeskik TheNeskik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 116 'park_pos' should be 'parkpos' without '_'
Same at line 166 and 228.

After the bed is heated to the target temperature, the probe doesn't go down to the heating point.

@thinkyhead
Copy link
Member Author

thinkyhead commented Feb 28, 2020 •
edited
Loading

@TheNeskik — When a test is obviously failing from a typo, and the contributor is off having dinner, there is no need to SPAM the PR about it. We can see compile errors right here on this page already.

@thinkyhead thinkyhead force-pushed the bf2_fix_g76_check_PR branch 2 times, most recently from 8dd1bd1 to 4ed3099 Compare February 28, 2020 01:30
@thinkyhead thinkyhead merged commit 97e87d8 into MarlinFirmware:bugfix-2.0.x Feb 28, 2020
@thinkyhead thinkyhead deleted the bf2_fix_g76_check_PR branch February 28, 2020 04:47
oechslein pushed a commit to oechslein/Marlin that referenced this pull request Mar 21, 2020
@thinkyhead @oechslein
Fix G76 reachable test (MarlinFirmware#17005)
8e0beb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheNeskik TheNeskik TheNeskik requested changes

Assignees
No one assigned
Labels
F: Calibration PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @TheNeskik