Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKS SBase Digipot init fix #16662

Conversation

Bob-the-Kuhn
Copy link
Contributor

MKS SBASE boards no longer compile because of a bug introduced by PR #16584. This PR replaced digipot_mcp4451_init() with configure_i2c() but the replacement was not completed.

CHANGES:

  • digipot_mcp4451.cpp - replace configure_i2c() with configure_i2c(0xFF). That routine reqwuires one argument. The 0xFF value guarantees the faster speed is always selected (the speed specified by digipot_mcp4451_init).
  • digipot_mcp4451_I2C_routines.h - add declaration for configure_i2c

This fix has been tested on a MKS SBase V1.3 board.

@0r31
Copy link
Contributor

0r31 commented Jan 24, 2020

Hi @Bob-the-Kuhn ,

The introduction of the i2c_util stuff makes compilation failing using digipot or u8g.
That's why I already created a PR to solve both issues : #16636 .

Regards,
Orel

@Bob-the-Kuhn
Copy link
Contributor Author

PR #16636 includes this fix plus another. Closing this PR.

@Bob-the-Kuhn Bob-the-Kuhn deleted the MKS-Sbase-gigipot-init-fix branch January 29, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants