Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32F1: Align SD EEPROM data for SDIO #14809

Merged

Conversation

tpruvot
Copy link
Contributor

@tpruvot tpruvot commented Aug 2, 2019

Some users reported possible alignment issues with the sdio code... see PR #14802

@tpruvot tpruvot changed the title STM32F1: alignment compat. with SDIO pointers STM32F1: eeprom alignment compat. with SDIO pointers Aug 2, 2019
@tpruvot
Copy link
Contributor Author

tpruvot commented Aug 2, 2019

btw... maybe its time to move this feature in shared code... like other sdcard features

@thinkyhead
Copy link
Member

I did a minor consolidation of EEPROM emulation code recently, so anything that helps to keep that going is a good thing.

@thinkyhead thinkyhead merged commit 3334163 into MarlinFirmware:bugfix-2.0.x Aug 2, 2019
@thinkyhead thinkyhead changed the title STM32F1: eeprom alignment compat. with SDIO pointers STM32F1: Align SD EEPROM data for SDIO Aug 2, 2019
@tpruvot tpruvot deleted the stm32f1_sdcard_align branch August 2, 2019 09:19
@pinchies
Copy link
Contributor

pinchies commented Aug 2, 2019

I can confirm this PR has fixed SD as eeprom.

Next in line: STM32F1 flash as eeprom - still not working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants