Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fysetc stm32flash usage #14703

Merged
merged 1 commit into from
Jul 22, 2019
Merged

fix: fysetc stm32flash usage #14703

merged 1 commit into from
Jul 22, 2019

Conversation

trouch
Copy link
Contributor

@trouch trouch commented Jul 22, 2019

Requirements

PlatformIO

Description

  • Defines UPLOADER env var using platformio package, avoiding stm32flash system install
  • Release RTS as part of bootloader enter sequence
  • Set firmware start address to properly reset the device after flashing, post-flash reset isn't working otherwise.
  • Double quoting paths for safety

@thinkyhead thinkyhead merged commit a6bec53 into MarlinFirmware:bugfix-2.0.x Jul 22, 2019
@sl1pkn07
Copy link
Contributor

Defines UPLOADER env var using platformio package, avoiding stm32flash system install

why this?

tpruvot added a commit to tpruvot/Marlin that referenced this pull request Aug 9, 2019
@tpruvot
Revert "Fix FYSETC stm32flash usage (MarlinFirmware#14703)"
b510d86 
This reverts commit a6bec53.

+ Use os.path.join() to handle possible spaces in BUILD_DIR
@trouch trouch deleted the fix/fysetc-uploader branch August 11, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: STM32 C: Build / Toolchain PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trouch @sl1pkn07 @thinkyhead