Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games, for fun (and stress-testing) #13464

Merged

Conversation

thinkyhead
Copy link
Member

Some badly-implemented mini-games for the people. Some frivolity ahead of MRRF 2019.

@thinkyhead thinkyhead force-pushed the bf2_games_for_fun branch 2 times, most recently from 7c61baa to 79194c8 Compare March 24, 2019 09:45
@AnHardt
Copy link
Contributor

AnHardt commented Mar 24, 2019

I hoped we'd have the 1st of April.
But no. =:-o

@thinkyhead
Copy link
Member Author

It's such a parody (and meta-parody) regardless of the date, so I decided to put it out early.

@thinkyhead thinkyhead force-pushed the bf2_games_for_fun branch 2 times, most recently from 523c15e to 4a65d42 Compare March 25, 2019 00:20
@marcio-ao
Copy link
Contributor

@thinkyhead: Oh man, can't wait to try this! Now I guess we have to add games for our color LCD...

@marcio-ao
Copy link
Contributor

marcio-ao commented Mar 28, 2019

@thinkyhead: This. is. awesome.

I get a compile error with the maze one, but the others work great on our Mini 2! With the Maze, I get the following error:

In file included from src/lcd/menu/menu_game.cpp:27:0:
src/lcd/menu/menu_game.cpp: In function ‘void menu_game()’:
src/lcd/menu/menu_game.cpp:1024:36: error: ‘lcd_goto_maze’ was not declared in this scope
       MENU_ITEM(submenu, MSG_MAZE, lcd_goto_maze);
                                    ^
src/lcd/menu/menu.h:276:45: note: in definition of macro ‘_MENU_ITEM_VARIANT_P’
         MenuItem_##TYPE ::action ## VARIANT(__VA_ARGS__); \
                                             ^
src/lcd/menu/menu_game.cpp:1024:7: note: in expansion of macro ‘MENU_ITEM’
       MENU_ITEM(submenu, MSG_MAZE, lcd_goto_maze);
       ^

I'll try tracking this down.

@marcio-ao
Copy link
Contributor

I guess the maze isn't implemented? Maybe that's the April fools joke?

@marcio-ao
Copy link
Contributor

Some badly-implemented mini-games for the people.

These games are perfect! They work great! Not sure what is badly implemented about them...

@thinkyhead
Copy link
Member Author

I'm glad you like them and they aren't broken. The maze game is still under development.

@psavva
Copy link
Contributor

psavva commented Mar 31, 2019

LOL, I'll be trying this out :)
If you can play a game while waiting for a print to finish would be cool :P

@marcio-ao
Copy link
Contributor

If you can play a game while waiting for a print to finish would be cool :P

In "hard" mode, a "Game Over" means your print stops and you can't recover it :)

@thinkyhead thinkyhead merged commit 5de7b5b into MarlinFirmware:bugfix-2.0.x Apr 1, 2019
thinkyhead added a commit that referenced this pull request Apr 1, 2019
@Roxy-3D
Copy link
Member

Roxy-3D commented Apr 5, 2019

Is the Maze being worked on? That is the one I want to see working!

@marcio-ao
Copy link
Contributor

Is the Maze being worked on? That is the one I want to see working!

Is it 3D like Doom? :)

Bob-the-Kuhn pushed a commit to Bob-the-Kuhn/Marlin-Bob-2 that referenced this pull request Apr 5, 2019
Bob-the-Kuhn pushed a commit to Bob-the-Kuhn/Marlin-Bob-2 that referenced this pull request Apr 16, 2019
@thinkyhead thinkyhead deleted the bf2_games_for_fun branch June 27, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants