-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add G38.4 and G38.5 #13348
Add G38.4 and G38.5 #13348
Conversation
d787f6d
to
743af33
Compare
Looks good. As soon as it passes it can be merged. I don't recommend trying to piggyback MK2 skew calibration onto |
6f74d36
to
2d5784e
Compare
To get this rebased, squashed branch to your working copy:
|
Thank you very much, looking forward to seeing this get merged |
i look forward to this also :-D the only thing i'm not sure on is my probe offset, the nozzle can go to 0,0 when i ask it to and i can place the nozzle on the 250,210 corner diagional to 0,0 so i assume that my X and Y min numbers are correct so far i have used bilinear and some carefull selected numbers to get it to hit the 9 prove points on the bed, but it has always seemed like the probe was not on dead center how can i check that my offset is correct ? (just asking so i can prepare for when the next bit is added) |
Marlin/src/module/endstops.cpp
Outdated
@@ -672,14 +672,17 @@ void Endstops::update() { | |||
}while(0) | |||
|
|||
#if ENABLED(G38_PROBE_TARGET) && PIN_EXISTS(Z_MIN_PROBE) && !(CORE_IS_XY || CORE_IS_XZ) | |||
#if ENABLED(G38_PROBE_AWAY) | |||
#define _G38_OPEN_STATE (G38_move > 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkyhead I think this is a bug, this should be a 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I usually double-check my late-night coding the next day, but I was about ready to just merge and forget!
Part of the calibration is calibration is calculating this offset translation. My endstops on my clone are out of spec so I expect this to come up during my testing |
Co-Authored-By: Michiel Baird <[email protected]>
Co-Authored-By: Michiel Baird <[email protected]>
7d6c19d
to
e97d9df
Compare
Requirements
Description
Add support for G38.4 and G38.5
This adds the option to move away from the target and stop as soon as the Z-endstop stops being triggered. See: http://linuxcnc.org/docs/2.6/html/gcode/gcode.html#sec:G38-probe
Benefits
Related Issues
#6199