Software reset via panel button press #13091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing the kill button a second time (once in killed state) will call the Arduino reset vector and restart Marlin. Signed-off-by: Bruce Beare <[email protected]>
|
It's a good concept, but… This technique to reset the board doesn't work reliably. We had a long thread about it. If I can find the issue number, I will post a link. |
|
Thanks, please do. Glad to rework. |
|
See #8994 for a discussion of the reset problems. |
|
Putting my printer back together after a bit of upgrade. I'll try this out today or tomorrow. |
|
I would love to see this work. I can test on the re-arm |
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
c24d616 to
ab781de
Compare
|
I, great job, many Thanks ! BestEDIT : I test on my re-arm. It's OK. First click Kill Marlin. Second click reset it ! Thanks. |
|
I'll test on the re-arm and let you know how it went.
…On Sun, 10 Mar 2019, 17:15 J-charles-C, ***@***.***> wrote:
I,
great job, many Thanks !
Best
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13091 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYyptoKSBtM9_u0KYov2yR9Y7oiZunyks5vVSGOgaJpZM4amZ8h>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the kill button a second time (once in killed state)
will call the Arduino reset vector and restart Marlin.
Signed-off-by: Bruce Beare [email protected]
Requirements
Description
Benefits
No longer have to power cycle after hitting the front panel switch (if HAS_KILL). Instead, you can press it a second time and the board restarts Marlin.
Related Issues