Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] in temperature.cpp #25953

Closed
mriscoc opened this issue Jun 9, 2023 · 3 comments · Fixed by #25954
Closed

[BUG] in temperature.cpp #25953

mriscoc opened this issue Jun 9, 2023 · 3 comments · Fixed by #25954
Labels
C: Temperatures

Comments

@mriscoc
Copy link
Contributor

mriscoc commented Jun 9, 2023 •
edited
Loading

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Error in the definition of _MINMAX_TEST(N,M)

https://github.com/MarlinFirmware/Marlin/blob/f3cda01b959274e7930c2050f5e34aa1460791bc/Marlin/src/module/temperature.cpp#LL2946C6-L2946C6

Bug Timeline

Current bugfix

Expected behavior

_MINMAX_TEST must be defined as:

    #define _MINMAX_TEST(N,M) (HOTENDS > N && TEMP_SENSOR_##N##_IS_THERMISTOR && defined(HEATER_##N##_##M##TEMP))

Actual behavior

_MINMAX_TEST is defined as:

    #define _MINMAX_TEST(N,M) (HOTENDS > N && TEMP_SENSOR_##NR##_IS_THERMISTOR && defined(HEATER_##N##_##M##TEMP))

Version of Marlin Firmware

Latest Marlin Bugfix
mriscoc added a commit to mriscoc/Marlin that referenced this issue Jun 9, 2023
@mriscoc
Fix MarlinFirmware#25953
6e17324 
_MINMAX_TEST must be defined as:

```cpp
    #define _MINMAX_TEST(N,M) (HOTENDS > N && TEMP_SENSOR_##N##_IS_THERMISTOR && defined(HEATER_##N##_##M##TEMP))
```
@mriscoc
Copy link
Contributor Author

mriscoc commented Jun 9, 2023

PR: #25954

@thisiskeithb
Copy link
Member

FYI: To save some time/work for yourself, you don't need to create an issue if you plan to submit a PR with a fix.

@mriscoc mriscoc mentioned this issue Jun 9, 2023
Closed
@thisiskeithb thisiskeithb linked a pull request Jun 9, 2023 that will close this issue
Fix Thermistor Min/Max Test #25954
Merged
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C: Temperatures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Thermistor Min/Max Test mriscoc/Marlin
2 participants
@mriscoc @thisiskeithb