Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] new build warnings introduced for ZONESTAR_LCD #21089

Closed
atsju opened this issue Feb 15, 2021 · 2 comments
Closed

[BUG] new build warnings introduced for ZONESTAR_LCD #21089

atsju opened this issue Feb 15, 2021 · 2 comments

Comments

@atsju
Copy link
Contributor

atsju commented Feb 15, 2021

Bug Description

The commit 4a89731 from PR #20753 has introduced new warnings during build.

In file included from Marlin\src\module\../lcd/marlinui.h:28:0,
                 from Marlin\src\module\temperature.cpp:37:
Marlin\src\module\../lcd/buttons.h:154:0: warning: "BUTTON_CLICK" redefined
     #define BUTTON_CLICK() RRK(EN_KEYPAD_MIDDLE)
 ^
Marlin\src\module\../lcd/buttons.h:123:0: note: this is the location of the previous definition
     #define BUTTON_CLICK() (buttons & (B_MI|B_ST))

Configuration Files

simply define #define ZONESTAR_LCD

Steps to Reproduce

It's a build warning, no special steps to reproduce.
Note that in tip of branche in file pins_RAMPS.h line 471 there is now an error to warn user for HW modification so I suppose this warning will never be found by automated builds.

I expect to build without warnings
Actual behavior:
Build warnings

@ellensp
Copy link
Contributor

ellensp commented Feb 16, 2021

This has been merged.

@ellensp ellensp closed this as completed Feb 16, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants