Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot compile with ADVANCED_PAUSE_FEATURE without PREVENT_COLD_EXTRUSION #19463

Closed
sjasonsmith opened this issue Sep 21, 2020 · 4 comments

Comments

@sjasonsmith
Copy link
Contributor

Bug Description

If ADVANCED_PAUSE_FEATURE is enabled, you cannot compile with PREVENT_COLD_EXTRUSION disabled, due to the following error:

Marlin\src\feature\pause.cpp: In function 'bool ensure_safe_temperature(bool, PauseMode)':
Marlin\src\feature\pause.cpp:132:51: error: 'class Temperature' has no member named 'extrude_min_temp'
     thermalManager.setTargetHotend(thermalManager.extrude_min_temp, active_extruder);

I believe this was introduced by a recent change which added some heating logic when resuming from pause. I wasn't quite sure how to resolve this build failure, without possibly undoing the intentions of the prior change.
828a582

I frequently use PREVENT_COLD_EXTRUSIONS when reproducing bug reports. It allows me to reproduce problems with heaters disabled and no filament loaded.

My Configurations

These are the default configurations, with minimal changes to reproduce the build failure.
Configurations_COLD_EXTRUSION.zip

Steps to Reproduce

  1. Build.

Additional Information

N/A

@rlojek
Copy link
Contributor

rlojek commented Oct 13, 2020

Confirmed, both bugfix and 2.7.x branches.

@rlojek
Copy link
Contributor

rlojek commented Oct 13, 2020

I did some research, in temerature.h field extrude_min_temp is declared conditionally in respect to PREVENT_COLD_EXTRUSION. This was not changed recently, yet how the ensure_safe_temperature handles this has changed:
2.6.1 no use of the field
2.0.7 and 2.0.x use that field:
https://github.com/MarlinFirmware/Marlin/blob/da79674f84ef65cb014288a27d60f8709b1f0936/Marlin/src/feature/pause.cpp#L136
Either set a default value to extrude_min_temp as 0 or change to ensure_save_temperature is needed. I'm waiting for a suggestion how to fix that issue.

rlojek pushed a commit to rlojek/Marlin that referenced this issue Oct 14, 2020
…nFirmware#19463)

Setting min hotend temperature in pause.ccp under conditional compilation triggered by PREVENT_COLD_EXTRUSION
rlojek pushed a commit to rlojek/Marlin that referenced this issue Oct 14, 2020
@sjasonsmith
Copy link
Contributor Author

Thanks for the fix, @rlojek!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants