[Bug] Ender 3V2 z-offset tuning not working #18787

cosmoderp · 2020-07-26T07:02:09Z

Bug Description

z-offset does not change live when using the tuning menu. I even cranked it all the way down to -6.72 without a bed crash.

My Configurations

@CRCinAU for configurations since its he keeps it private

Steps to Reproduce

start test print
go to tune menu
adjust z offset while printing
press button to commit
observe behavior

Expected behavior: when you adjust the z-offset while printing the z-offset should change.

Actual behavior: it does not respond to any changes.
https://www.youtube.com/watch?v=6C7-YI-uQ9s

ellensp · 2020-07-26T07:45:58Z

Cannot assist if you cannot attach config files.

cosmoderp · 2020-07-26T08:45:08Z

I mean it was the ender 3 v2 using DWIN. setting z-offset works and you can save it but the live tuning adjustments dont.

Dunno if thinkyhead still has this printer and might be able to say its just me alone having this issue anyway.

boelle · 2020-07-26T09:27:31Z

Configurations, please
Please ZIP up your Configuration.h and Configuration_adv.h files (as
requested in the Issue template) and drop them into your next reply.
We'll check them over and see if anything is amiss.

The issue template ask for those (if you even read the template) and they are easy to attach wo why not do it so that others have an chance of helping you

fleek · 2020-07-26T13:48:57Z

Not sure if this is a bug in Conditionals_LCD.H

#if ANY(HAS_Z_SERVO_PROBE, FIX_MOUNTED_PROBE, NOZZLE_AS_PROBE, TOUCH_MI_PROBE, Z_PROBE_ALLEN_KEY, Z_PROBE_SLED, SOLENOID_PROBE, SENSORLESS_PROBING, RACK_AND_PINION_PROBE) #define HAS_BED_PROBE 1 #endif

BLTOUCH is not specified.

CRCinAU · 2020-07-26T14:39:42Z

@fleek - I think you're on the right path here - the DWIN menu structure has:

inline void Prepare_Item_Offset(const uint8_t row) {
  if (HMI_flag.language_flag) {
    #if HAS_BED_PROBE
      DWIN_Frame_AreaCopy(1, 174, 164, 271 - 48, 479 - 302, LBLX, MBASE(row));
      show_plus_or_minus(font8x16, Background_black, 2, 2, 202, MBASE(row), probe.offset.z * 100);
    #else
      DWIN_Frame_AreaCopy(1, 43, 89, 271 - 173, 479 - 378, LBLX, MBASE(row));
    #endif
  }
  else {
    #if HAS_BED_PROBE
      DWIN_Frame_AreaCopy(1, 93, 179, 271 - 130, 479 - 290, LBLX, MBASE(row)); // "Z-Offset"
      show_plus_or_minus(font8x16, Background_black, 2, 2, 202, MBASE(row), probe.offset.z * 100);
    #else
      DWIN_Frame_AreaCopy(1, 1, 76, 271 - 165, 479 - 393, LBLX, MBASE(row)); // "..."
    #endif
  }
  Draw_Menu_Line(row, ICON_SetHome);
}

Therefore, if HAS_BED_PROBE is not defined, this won't get built into the screen.

Pointing to your suggestion here seems sane:
https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/inc/Conditionals_LCD.h#L621

CRCinAU · 2020-07-26T14:48:45Z

Here is where the actual Offset gets applied:
https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/lcd/dwin/dwin.cpp#L1090

Specifically, this part:

else if (encoder_diffState == ENCODER_DIFF_ENTER) {
      EncoderRate.encoderRateEnabled = 0;
      zprobe_zoffset                 = HMI_ValueStruct.offset_value / 100;
      #if HAS_BED_PROBE
        if (WITHIN(zprobe_zoffset - last_zoffset, Z_PROBE_OFFSET_RANGE_MIN, Z_PROBE_OFFSET_RANGE_MAX))
          probe.offset.z = zprobe_zoffset;
        settings.save();
      #elif ENABLED(BABYSTEPPING)
        babystep.add_mm(Z_AXIS, (zprobe_zoffset - last_zoffset));
      #else
        UNUSED(zprobe_zoffset - last_zoffset);
      #endif

      if (HMI_ValueStruct.show_mode == -4) {
        checkkey = Prepare;
        show_plus_or_minus(font8x16, Background_black, 2, 2, 202, MBASE(4 + MROWS - index_prepare), TERN(HAS_LEVELING, probe.offset.z * 100, HMI_ValueStruct.offset_value));
      }
      else {
        checkkey = Tune;
        show_plus_or_minus(font8x16, Background_black, 2, 2, 202, MBASE(5 + MROWS - index_tune), TERN(HAS_LEVELING, probe.offset.z * 100, HMI_ValueStruct.offset_value));
      }
      DWIN_UpdateLCD();
      return;
    }

I'm a bit confused by this logic... I can only assume that the HAS_BED_PROBE case is used for setting an offset with a probe attached, but it will fall back to using BABYSTEPPING if we don't have a probe configured in...

cosmoderp · 2020-07-27T20:06:50Z

config files.zip

as requested

fleek · 2020-07-27T20:57:22Z

@cosmoderp can you pull from my repo fleek/Marlin:bugfix-2.0.x and test if the fix works for you. If it works I will push the fix to the main repo.

sjasonsmith · 2020-07-28T02:55:26Z

I mean it was the ender 3 v2 using DWIN and I was nice enough to provide a video

Nothing in the title or description indicated this was an Ender 3 V2 or that it was DWIN. Videos are useful, but it's not reasonable to expect people to go watch videos when quickly screening issues to see if they can help.

It looks like there are configs attached now and someone is already trying to help, so hopefully something can be figured out.

cosmoderp · 2020-07-28T04:04:39Z

@fleek just tested it ... sorry had gone to work. Does not seem to have fixed it for me. I cranked it down all the way to -10 while printing a test print. and it should be around 4ish mm when bed crash. if there are changes to the main config file though and I was meant to simply make all the needed changes myself be advise. I am still pretty new to this and still used my original config files. thanks for your help.

fleek · 2020-07-28T04:15:47Z

@cosmoderp I am not sure about the units, but I think when you dial in 10, it will only move like 10/100 or 0.1mm, so you might want to dial in more to test.

cosmoderp · 2020-07-28T05:12:54Z

well what I did was max is out....the limit is z-offset -10mm. Baby stepping via commands works so I know it does that. I also just found that there was an option that lets you change the z-offset with the babysteps that I might turn on. Also to verify movement I both watched the motor and light laid my finger on the spindle to detect even the slightest movement.

CRCinAU · 2020-07-28T06:13:46Z

Yeah - the units here are in mm - the marlin limitation is +/- 10mm by default, and adjustable in 0.01mm increments.

fleek · 2020-07-28T15:13:40Z

@cosmoderp Can you please add to the title '[Bug] Ender 3V2' so that it can be identified specifically, because I think this problem is specific to Ender 3V2 because of the DWIN DGUS controller. I am trying to resolve this together with #18800, so it will take some time. The DWIN DGUS controller is still an unknown to me as well, as to the tools required and how the marlin firmware interacts with it.

lwaynej · 2020-08-14T02:05:35Z

I think I am seeing a similar issue. My printer uses the SKR 1.4 and I use a BLTouch for the Z endstop (I am not using bed leveling at this point, it is turned off in the printer settings.) I suspect this is a configuration issue.

I was using 2.0.5.3 as a base. My code is now based on 2.0.6 (84b96d3) and the Z probe offset no longer appears to work. My probe offset is about -2.22. Now matter what I see the offset to in the menu the distance between the nozzle and the bed are about -2.23 after auto home and moving Z to 0.
I have diff'd Configuration.h and Configuration_Adv.h between the working and none working builds and the only differences occur in things that changed between the two releases.

Here are my observations:

Z homing was not working at all until I uncommented "USE_PROBE_FOR_Z_HOMING"
(After enabling) Z Homing with the BlTouch only does the fast probe. Previously it did a fast probe to figure out where it was at and then a slow probe for accuracy (I don't see an obvious way to change this.) Maybe this change was intended ...
The Z probe offset is being ignored. The zero position for the Z axis is always the same (I turn off soft end stops and adjust the gap using 0.1 mm feeler gauge.) I have configured #define NOZZLE_TO_PROBE_OFFSET { 0, -41, -2.22}. After homing and using "Move Axis" to set my Z to 0 I am still 2.22 mm above where I want it to be. Using the configuration menu I have set the offset to -4.44 and I am still 2.22 mm above where I want the axis to be.

I have (I hope) attached my Configation.h and Configuration_Adv.h.

MarlinConfig-2.0.6.tar.gz

cosmoderp · 2020-08-28T07:37:02Z

I figured out why this was not working on my ender 3 v2 todays perhaps you have a new bug. It turned out that creality made a mistake when designing the menu. It was a simple mistake in programming the menu. I have mine working now the way its supposed to be. lwaynej perhaps you should start a new bug report by the looks of your issue. Make sure you that you reset the eeprom, save it, then powercycle first. Just in case.

cosmoderp · 2020-08-28T07:38:30Z

This turned out to be a simple menu programming error of the menu. I have been working on a menu and hope to push out a fix soon.

SlackHacky · 2020-08-28T20:25:47Z

@cosmoderp would love the menu fix info

brianjackson1 · 2020-09-13T19:46:39Z

@cosmoderp
Has this been added to the nightly builds yet?

cosmoderp · 2020-09-13T21:18:25Z

I did a pull request today.....sorry it took so long I had to learn how to use git

brianjackson1 · 2020-09-14T18:12:51Z

Many thanks for all your work on this. Hopefully it will be added to the next nightly build.

ivanwong1989 · 2020-09-24T09:45:37Z

Question. To have this fix, i just need to download and compile bugfix branch and flash the printer? Do i need to flash the LCD as well? i think with DWIN_SET?

brianjackson1 · 2020-09-24T17:07:43Z

Having looked at #19384 I believe the fix is actually in the Marlin Dwin file which at the moment is just a work in progress. Looks like we have to wait a while longer for this to be released.

github-actions · 2020-11-24T14:05:08Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

fleek pushed a commit to fleek/Marlin that referenced this issue Jul 27, 2020

Test fix MarlinFirmware#18787

e2a91c3

cosmoderp changed the title ~~z-offset tuning not working~~ [Bug] Ender 3V2 z-offset tuning not working Jul 28, 2020

cosmoderp closed this as completed Aug 28, 2020

cosmoderp mentioned this issue Sep 13, 2020

Fix for setting offset from tune menu (ender 3 v2) #19384

Merged

github-actions bot locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Ender 3V2 z-offset tuning not working #18787

[Bug] Ender 3V2 z-offset tuning not working #18787

cosmoderp commented Jul 26, 2020

ellensp commented Jul 26, 2020

cosmoderp commented Jul 26, 2020 •

edited

Loading

boelle commented Jul 26, 2020 •

edited

Loading

fleek commented Jul 26, 2020 •

edited

Loading

CRCinAU commented Jul 26, 2020

CRCinAU commented Jul 26, 2020

cosmoderp commented Jul 27, 2020

fleek commented Jul 27, 2020

sjasonsmith commented Jul 28, 2020

cosmoderp commented Jul 28, 2020

fleek commented Jul 28, 2020

cosmoderp commented Jul 28, 2020 •

edited

Loading

CRCinAU commented Jul 28, 2020

fleek commented Jul 28, 2020

lwaynej commented Aug 14, 2020

cosmoderp commented Aug 28, 2020

cosmoderp commented Aug 28, 2020

SlackHacky commented Aug 28, 2020

brianjackson1 commented Sep 13, 2020

cosmoderp commented Sep 13, 2020 •

edited

Loading

brianjackson1 commented Sep 14, 2020

ivanwong1989 commented Sep 24, 2020

brianjackson1 commented Sep 24, 2020

github-actions bot commented Nov 24, 2020

[Bug] Ender 3V2 z-offset tuning not working #18787

[Bug] Ender 3V2 z-offset tuning not working #18787

Comments

cosmoderp commented Jul 26, 2020

Bug Description

My Configurations

Steps to Reproduce

ellensp commented Jul 26, 2020

cosmoderp commented Jul 26, 2020 • edited Loading

boelle commented Jul 26, 2020 • edited Loading

fleek commented Jul 26, 2020 • edited Loading

CRCinAU commented Jul 26, 2020

CRCinAU commented Jul 26, 2020

cosmoderp commented Jul 27, 2020

fleek commented Jul 27, 2020

sjasonsmith commented Jul 28, 2020

cosmoderp commented Jul 28, 2020

fleek commented Jul 28, 2020

cosmoderp commented Jul 28, 2020 • edited Loading

CRCinAU commented Jul 28, 2020

fleek commented Jul 28, 2020

lwaynej commented Aug 14, 2020

cosmoderp commented Aug 28, 2020

cosmoderp commented Aug 28, 2020

SlackHacky commented Aug 28, 2020

brianjackson1 commented Sep 13, 2020

cosmoderp commented Sep 13, 2020 • edited Loading

brianjackson1 commented Sep 14, 2020

ivanwong1989 commented Sep 24, 2020

brianjackson1 commented Sep 24, 2020

github-actions bot commented Nov 24, 2020

cosmoderp commented Jul 26, 2020 •

edited

Loading

boelle commented Jul 26, 2020 •

edited

Loading

fleek commented Jul 26, 2020 •

edited

Loading

cosmoderp commented Jul 28, 2020 •

edited

Loading

cosmoderp commented Sep 13, 2020 •

edited

Loading