[BUG]Compile error when enable #define POWER_MONITOR_CURRENT #18547

ccccmagicboy · 2020-07-05T10:14:40Z

Bug Description

I got this compile error below when I enabled #define POWER_MONITOR_CURRENT in Configuration_adv.h file.

It is seem that function define of ftostr21ns() and ui16tostr4() are not founded.

I want to test with this new feature, is there any clue to fix it?

Compiling .pio\build\STM32F103RC_meeb\src\src\feature\touch\xpt2046.cpp.o
Marlin\src\feature\power_monitor.cpp: In static member function 'static void PowerMonitor::draw_current()':
Marlin\src\feature\power_monitor.cpp:51:34: error: 'ftostr21ns' was not declared in this scope
       lcd_put_u8str(amps < 100 ? ftostr21ns(amps) : ui16tostr4((uint16_t)amps));
                                  ^~~~~~~~~~
Marlin\src\feature\power_monitor.cpp:51:34: note: suggested alternative: 'dtostrf'
       lcd_put_u8str(amps < 100 ? ftostr21ns(amps) : ui16tostr4((uint16_t)amps));
                                  ^~~~~~~~~~
                                  dtostrf
Marlin\src\feature\power_monitor.cpp:51:53: error: 'ui16tostr4' was not declared in this scope
       lcd_put_u8str(amps < 100 ? ftostr21ns(amps) : ui16tostr4((uint16_t)amps));
                                                     ^~~~~~~~~~
Marlin\src\feature\power_monitor.cpp:51:53: note: suggested alternative: 'dtostrf'
       lcd_put_u8str(amps < 100 ? ftostr21ns(amps) : ui16tostr4((uint16_t)amps));
                                                     ^~~~~~~~~~
                                                     dtostrf
Marlin\src\feature\power_monitor.cpp: In static member function 'static void PowerMonitor::draw_voltage()':
Marlin\src\feature\power_monitor.cpp:59:35: error: 'ftostr21ns' was not declared in this scope
       lcd_put_u8str(volts < 100 ? ftostr21ns(volts) : ui16tostr4((uint16_t)volts));
                                   ^~~~~~~~~~
Marlin\src\feature\power_monitor.cpp:59:35: note: suggested alternative: 'dtostrf'
       lcd_put_u8str(volts < 100 ? ftostr21ns(volts) : ui16tostr4((uint16_t)volts));
                                   ^~~~~~~~~~
                                   dtostrf
Marlin\src\feature\power_monitor.cpp:59:55: error: 'ui16tostr4' was not declared in this scope
       lcd_put_u8str(volts < 100 ? ftostr21ns(volts) : ui16tostr4((uint16_t)volts));
                                                       ^~~~~~~~~~
Marlin\src\feature\power_monitor.cpp:59:55: note: suggested alternative: 'dtostrf'
       lcd_put_u8str(volts < 100 ? ftostr21ns(volts) : ui16tostr4((uint16_t)volts));
                                                       ^~~~~~~~~~
                                                       dtostrf
Marlin\src\feature\power_monitor.cpp: In static member function 'static void PowerMonitor::draw_power()':
Marlin\src\feature\power_monitor.cpp:67:35: error: 'ftostr21ns' was not declared in this scope
       lcd_put_u8str(power < 100 ? ftostr21ns(power) : ui16tostr4((uint16_t)power));
                                   ^~~~~~~~~~
Marlin\src\feature\power_monitor.cpp:67:35: note: suggested alternative: 'dtostrf'
       lcd_put_u8str(power < 100 ? ftostr21ns(power) : ui16tostr4((uint16_t)power));
                                   ^~~~~~~~~~
                                   dtostrf
compilation terminated due to -fmax-errors=5.
*** [.pio\build\STM32F103RC_meeb\src\src\feature\power_monitor.cpp.o] Error 1
============================================================================================== [FAILED] Took 31.27 seconds ==============================================================================================

Environment               Status    Duration
------------------------  --------  ------------
mega2560                  IGNORED
mega1280                  IGNORED
MightyBoard1280           IGNORED
MightyBoard2560           IGNORED
rambo                     IGNORED
FYSETC_F6_13              IGNORED
FYSETC_F6_14              IGNORED
sanguino644p              IGNORED
sanguino1284p             IGNORED
melzi                     IGNORED
melzi_optiboot            IGNORED
melzi_optimized           IGNORED
at90usb1286_cdc           IGNORED
at90usb1286_dfu           IGNORED
DUE                       IGNORED
DUE_USB                   IGNORED
DUE_debug                 IGNORED
DUE_archim                IGNORED
DUE_archim_debug          IGNORED
SAMD51_grandcentral_m4    IGNORED
LPC1768                   IGNORED
LPC1769                   IGNORED
STM32F103RC               IGNORED
STM32F103RC_meeb          FAILED    00:00:31.273
STM32F103RC_fysetc        IGNORED
STM32F103RC_btt           IGNORED
STM32F103RC_btt_USB       IGNORED
STM32F103RC_btt_512K      IGNORED
STM32F103RC_btt_512K_USB  IGNORED
STM32F103RE               IGNORED
STM32F103RE_btt           IGNORED
STM32F103RE_btt_USB       IGNORED
STM32F4                   IGNORED
STM32F7                   IGNORED
ARMED                     IGNORED
STM32F103VE_GTM32         IGNORED
STM32F103VE_longer        IGNORED
mks_robin_mini            IGNORED
mks_robin_nano            IGNORED
mks_robin_nano35          IGNORED
mks_robin                 IGNORED
mks_robin_pro             IGNORED
mks_robin_e3              IGNORED
mks_robin_lite            IGNORED
mks_robin_lite3           IGNORED
jgaurora_a5s_a1           IGNORED
STM32F103CB_malyan        IGNORED
STM32F070RB_malyan        IGNORED
malyan_M300               IGNORED
chitu_f103                IGNORED
chitu_v5_gpio_init        IGNORED
chitu_f103_lvgl           IGNORED
STM32F103RET6_creality    IGNORED
STM32F401VE_STEVAL        IGNORED
FLYF407ZG                 IGNORED
FYSETC_S6                 IGNORED
STM32F407VE_black         IGNORED
BIGTREE_SKR_PRO           IGNORED
BIGTREE_GTR_V1_0          IGNORED
BIGTREE_BTT002            IGNORED
rumba32                   IGNORED
esp32                     IGNORED
teensy31                  IGNORED
teensy35                  IGNORED
linux_native              IGNORED
include_tree              IGNORED

My Configurations

pins_CCROBOT_MEEB_3DP.zip
Marlin.zip

Steps to Reproduce

checkout newest bugfix-2.0.x branch
copy the config files and pin file include
compile the project in platformio

The text was updated successfully, but these errors were encountered:

ellensp · 2020-07-05T11:54:57Z

There are a bunch of similar functions in Marlin/src/libs/numtostr .h and .cpp just not ftostr21ns and ui16tostr4
ftostr31ns exists as does ui16tostr4rj try those... it just creates the strings that are displayed on the lcd.. so worse case lcd will be badly formatted.

ccccmagicboy · 2020-07-05T12:33:13Z

@ellensp Thanks for your tips, I will try it on.

sjasonsmith · 2020-07-05T19:40:22Z

@ccccmagicboy are you planning to fix this and submit a Pull Request yourself?

ccccmagicboy · 2020-07-06T03:26:57Z

@sjasonsmith Yes, let me do it. Any help appreciated!

ccccmagicboy · 2020-07-06T03:48:37Z

Let me guess ftostr21ns() mean format float to xx.x, and ui16tostr4() mean format uint16 to xxxx string, is that correct?

ccccmagicboy · 2020-07-06T07:36:34Z

@sjasonsmith
I Got confused, there seems to be a lot of work to be done, a little beyond my ability.

ellensp · 2020-07-06T07:48:12Z

"ftostr21ns() mean format float to xx.x"

That would be my guess since it only use this when value is less than 100
but if you read the comment for marlins ftostr31ns it also says // Convert unsigned float to string with 12.3 format
So seems to be the same thing, you you can just change ftostr21ns to ftostr31ns in power_monitor.cpp.

and "ui16tostr4() mean format uint16 to xxxx string"

Yes.

Marlin doesn't have one of these functions, closest is ui16tostr4rj (rj being right justified)
The difference being it still creates a string of 4 characters, but for eg if it was a value of 100 it would create the string ' 100' not '100' (no preceding spaces.)

ellensp · 2020-07-06T08:17:45Z

having a play, there are more things broken than just those two string conversions.

ellensp · 2020-07-06T09:09:03Z

right that was a mess. most of the lcd code was pre v2 code...
I have it working. will create a PR shortly

ellensp · 2020-07-06T10:25:24Z

The PR has been added.. It was quite broken........
But now, if you enable it, the last 5 characters of the display will display 4 digits and a A for amp, or a V for volts or a W for watts
NB you don't get Watts unless you enable both Volts and Amps.

This also enables gcode M430 eg:

SENDING:M430
Current: 96.01A Voltage: 1.70V Power: 163.52W

NB I don't have probes attached. these are just simulated values from a voltage divider.

ccccmagicboy · 2020-07-06T10:55:03Z

Great!, @ellensp I have the current sensor, let me test it.

ellensp · 2020-07-06T12:38:55Z

issue with eeprom fixed, I didn't know Power monitor saved any setting so missed it.

github-actions · 2020-09-05T02:01:53Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

ellensp added the Bug: Confirmed ! label Jul 5, 2020

ellensp pushed a commit to ellensp/Marlin that referenced this issue Jul 6, 2020

Solves: MarlinFirmware#18547 POWER_MONITOR fails to compile

db63abc

ellensp mentioned this issue Jul 6, 2020

Solves: #18547 POWER_MONITOR fails to compile #18561

Merged

thinkyhead closed this as completed Jul 6, 2020

ccccmagicboy mentioned this issue Jul 7, 2020

Use fix voltage instead #18579

Merged

github-actions bot locked and limited conversation to collaborators Sep 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG]Compile error when enable #define POWER_MONITOR_CURRENT #18547

[BUG]Compile error when enable #define POWER_MONITOR_CURRENT #18547

ccccmagicboy commented Jul 5, 2020

ellensp commented Jul 5, 2020 •

edited

Loading

ccccmagicboy commented Jul 5, 2020

sjasonsmith commented Jul 5, 2020

ccccmagicboy commented Jul 6, 2020

ccccmagicboy commented Jul 6, 2020 •

edited

Loading

ccccmagicboy commented Jul 6, 2020

ellensp commented Jul 6, 2020 •

edited

Loading

ellensp commented Jul 6, 2020

ellensp commented Jul 6, 2020

ellensp commented Jul 6, 2020

ccccmagicboy commented Jul 6, 2020 •

edited

Loading

ellensp commented Jul 6, 2020

github-actions bot commented Sep 5, 2020

[BUG]Compile error when enable #define POWER_MONITOR_CURRENT #18547

[BUG]Compile error when enable #define POWER_MONITOR_CURRENT #18547

Comments

ccccmagicboy commented Jul 5, 2020

Bug Description

My Configurations

Steps to Reproduce

ellensp commented Jul 5, 2020 • edited Loading

ccccmagicboy commented Jul 5, 2020

sjasonsmith commented Jul 5, 2020

ccccmagicboy commented Jul 6, 2020

ccccmagicboy commented Jul 6, 2020 • edited Loading

ccccmagicboy commented Jul 6, 2020

ellensp commented Jul 6, 2020 • edited Loading

ellensp commented Jul 6, 2020

ellensp commented Jul 6, 2020

ellensp commented Jul 6, 2020

ccccmagicboy commented Jul 6, 2020 • edited Loading

ellensp commented Jul 6, 2020

github-actions bot commented Sep 5, 2020

ellensp commented Jul 5, 2020 •

edited

Loading

ccccmagicboy commented Jul 6, 2020 •

edited

Loading

ellensp commented Jul 6, 2020 •

edited

Loading

ccccmagicboy commented Jul 6, 2020 •

edited

Loading