-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old/Forgotten "TRINAMICS" definitions in Conditionals_post.h #16961
Comments
added config files (I thing they are not relevant in this case) |
b00gie-dev
changed the title
Old/Forgotten "TRINAMICS" defintions in Conditionals_post.h
Old/Forgotten "TRINAMICS" definitions in Conditionals_post.h
Feb 25, 2020
Created a PR to fix this. |
Good catch, thanks! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In earlier releases there was an #define TRINAMICS in Conditionals_post.h. This define was replaced by "HAS_TRINAMIC || HAS_TRINAMIC_STANDALONE". But in line 648 and 668 are two old "TRINAMICS" leftovers. So I guess they also should be replaced with "HAS_TRINAMIC || HAS_TRINAMIC_STANDALONE".
By now this results in setting up wrong values for "MINIMUM_STEPPER_PULSE" and "MAXIMUM_STEPPER_RATE" when using TMC drivers. (see Screenshot)
Greets,
Niko
The text was updated successfully, but these errors were encountered: