Skip to content

Commit

Permalink
✨ Ender-3 V2 LCD with SKR 3[EZ] (#27061)
Browse files Browse the repository at this point in the history
  • Loading branch information
vrooze authored May 20, 2024
1 parent 98d09e5 commit 5a6db51
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Marlin/src/inc/Conditionals_adv.h
Original file line number Diff line number Diff line change
Expand Up @@ -1311,7 +1311,8 @@
* currently HAL.h must be included ahead of pins.h.
*/
#if LCD_IS_SERIAL_HOST && !defined(LCD_SERIAL_PORT)
#if MB(MKS_MONSTER8_V1, BTT_SKR_MINI_E3_V1_0, BTT_SKR_MINI_E3_V1_2, BTT_SKR_MINI_E3_V2_0, BTT_SKR_MINI_E3_V3_0, BTT_SKR_MINI_E3_V3_0_1, BTT_SKR_E3_TURBO, BTT_OCTOPUS_V1_1, AQUILA_V101)
#if MB(MKS_MONSTER8_V1, BTT_SKR_MINI_E3_V1_0, BTT_SKR_MINI_E3_V1_2, BTT_SKR_MINI_E3_V2_0, BTT_SKR_MINI_E3_V3_0, BTT_SKR_MINI_E3_V3_0_1, BTT_SKR_E3_TURBO, BTT_OCTOPUS_V1_1, BTT_SKR_V3_0, BTT_SKR_V3_0_EZ, AQUILA_V101)

#define LCD_SERIAL_PORT 1
#elif MB(CREALITY_V24S1_301, CREALITY_V24S1_301F4, CREALITY_F401RE, CREALITY_V423, CREALITY_CR4NTXXC10, MKS_ROBIN, PANOWIN_CUTLASS, KODAMA_BARDO)
#define LCD_SERIAL_PORT 2
Expand Down
23 changes: 23 additions & 0 deletions Marlin/src/pins/stm32h7/pins_BTT_SKR_V3_0_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,29 @@
#define TFTGLCD_CS EXP2_03_PIN
#endif

#elif HAS_DWIN_E3V2 || IS_DWIN_MARLINUI
/**
* ------ ------ ---
* | 1 2 | | 1 2 | 1 |
* | 3 4 | RX | 3 4 | TX | 2 | RX
* ENT 5 6 | BEEP ENT 5 6 | BEEP | 3 | TX
* B | 7 8 | A B | 7 8 | A | 4 |
* GND | 9 10 | VCC GND | 9 10 | VCC 5 |
* ------ ------ ---
* EXP1 DWIN TFT
*
* DWIN pins are labeled as printed on DWIN PCB. GND, VCC, A, B, ENT & BEEP can be connected in the same
* orientation as the existing plug/DWIN to EXP1. TX/RX need to be connected to the TFT port, with TX->RX, RX->TX.
*/
#ifndef NO_CONTROLLER_CUSTOM_WIRING_WARNING
#error "CAUTION! Ender-3 V2 display requires a custom cable. See 'pins_BTT_SKR_V3_0_common.h' for details. (Define NO_CONTROLLER_CUSTOM_WIRING_WARNING to suppress this warning.)"
#endif

#define BEEPER_PIN EXP1_06_PIN
#define BTN_EN1 EXP1_08_PIN
#define BTN_EN2 EXP1_07_PIN
#define BTN_ENC EXP1_05_PIN

#elif HAS_WIRED_LCD

#define BEEPER_PIN EXP1_01_PIN
Expand Down

3 comments on commit 5a6db51

@ellensp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing spaces on lines 449 and 450...

@thisiskeithb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing spaces on lines 449 and 450...

Looks like a bug in the pins formatting script since it passed CI and make format-pins -j doesn't find anything.

@ellensp
Copy link
Contributor

@ellensp ellensp commented on 5a6db51 May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes just added a rstrip(), and testing it.
#27108

Please sign in to comment.