Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align indent for temp residency, window & hysteresis #437

Merged
merged 6 commits into from
Mar 29, 2021
Merged

align indent for temp residency, window & hysteresis #437

merged 6 commits into from
Mar 29, 2021

Conversation

StuSerious
Copy link
Contributor

@StuSerious StuSerious commented Mar 14, 2021

Requirements

This PR has no specific requirements!

Description

Good Sunday everyone! This PR aims to apply the change over at MarlinFirmware/Marlin#21329 to all config files in this repo.

Benefits

Symmetry and order!

Related Issues

This PR has no related Issues!

TODOs:

  • recursively check all files again
  • find a more efficient way to replace changed values
  • manually add files with different values set (this is going to take the most time)
  • mark as ready and request review!

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
as discussed in MarlinFirmware/Marlin#21329
Copy link
Contributor Author

@StuSerious StuSerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these all look good and should need no further attention!

@StuSerious
Copy link
Contributor Author

I underestimated the other config files, this is now officially a weekend project 😄
hoping to get it done between today and tomorrow!

@thinkyhead
Copy link
Member

thinkyhead commented Mar 29, 2021

A better weekend project is to learn regular expressions! But actually for the final cleanup I ended up just using "global search" and then scanning down the results list in the editor looking for lines that weren't aligned, then search-and-replacing other literal instances of the same misaligned contents. Took about 10 minutes to get them all.

@thinkyhead thinkyhead marked this pull request as ready for review March 29, 2021 05:47
@thinkyhead thinkyhead merged commit 56a75f7 into MarlinFirmware:import-2.0.x Mar 29, 2021
@StuSerious
Copy link
Contributor Author

StuSerious commented Mar 29, 2021

@thinkyhead completely agree with you there.
I apologize, I had overestimated my skill and underestimated the amount of work needed.
Next time I'll open a PR it's going to be complete, and just needing review.

Again, my apologies.
Have a nice day!

~Ste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants