📝 [WIP] Clarify TJC display support

[thisiskeithb]

Description

• TJC displays are mostly unsupported due to missing graphics
• Copy Ender-3 S1 LCD Files README to Ender-3 V2 Neo folder

---

TJC display (ie what you have) uses TJC_SET/tjc.tft. We cannot generate those files, so there is no screen updates for this display provided by Marlin.

Originally posted by @ellensp in MarlinFirmware/Marlin#27446 (comment)

---

Benefits

Improves documentation for TJC displays

Related Issues

• [BUG] TJC display issues on Ender 3 V2 Neo Marlin#27446

[queeup]

Maybe @mriscos can help with this support? https://github.com/mriscoc/Special_Configurations/releases/tag/tjc

[thisiskeithb]

Maybe @mriscos can help with this support?

Marlin’s Ender-3 V2 LCD support / Pro UI has diverged quite a bit from @mriscoc’s fork, but if they are willing to patch things up, we’d appreciate the help.

[mriscoc]

For TJC compatibility the only option is to use the iconset 9
So change the line:
#define ICON 7 // 7.ICO
to

#define ICON 9 // 9.ICO

Sometime ago there was a way to select the iconset by defining:

#define USE_STOCK_DWIN_SET

But it is not present in current Marlin version. I think that some additional icons were added which are incompatible with the 9.ICO. But maybe the standard CrealityUI keeps the compatibility.

[ellensp]

USE_STOCK_DWIN_SET was removed in
commit MarlinFirmware/Marlin@0f09554
Perhaps it needs to be brought back.

[thinkyhead]

When icon set 9 is selected do all the icons appear and none are missing with the UIs that support the TJC screen? If so, then it sounds like whenever a TJC screen is selected then ICON should automatically be set to 9. And, if this means that a TJC screen cannot support MarlinUI because it needs more icons, then we can also add a sanity check for that, or if possible check for the alternative icon set and display different icons for MarlinUI in that case.

[thisiskeithb]

I've added 76fc9c0 & a8a75d6 Ender-3 V2 NEO README changes to the Ender-3 S1 README in 029db09.

I tried to make it clear that the Ender-3 V2 NEO README was copied from the Ender-3 S1 README in the commit title for b6d650d: "Copy Ender-3 S1 LCD Files README to Ender-3 V2 Neo folder" as well as the PR description, but let me know if there's a better way to highlight this in the future.

[thisiskeithb]

When icon set 9 is selected do all the icons appear and none are missing with the UIs that support the TJC screen?

I have a genuine DWIN screen, so I can't test this.

---

@albka1986: See @thinkyhead's comment above.

Using the latest bugfix-2.1.x, can you try changing:

#define ICON 7 // 7.ICO

to:

#define ICON 9 // 9.ICO

in dwin_set.h?

[albka1986]

I updated the line, but still see the issue with displaying info:

[ellensp]

the original code moves the text aroud also

Eg

void ICON_Control() {
  constexpr frame_rect_t ico = { 17, 226, 110, 100 };
  constexpr text_info_t txt = { 61, { 405, TERN(USE_STOCK_DWIN_SET, 446, 447) }, 27, 15 };
  ICON_Button(select_page.now == PAGE_CONTROL, ICON_Control_0, ico, txt, GET_TEXT_F(MSG_CONTROL));
}

So It needs more than just #define ICON 9

[albka1986]

What should I change? Could you please clarify?