Correct start.sh and documentation for use of WEBUI_PORT and INCOMING_PORT environment variables #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected escaping of \ when updating WEBUI Port for an existing qBittorrent.conf file
sed requires triple backslashes (\) for proper escaping
Dropped "_ENV" suffix from WEBUI_PORT and INCOMING_PORT environment variable names to match references in start.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation references WEBUI_PORT_ENV and INCOMING_PORT_ENV, but these variables are referenced in the /etc/qbittorent scripts as WEBUI_PORT, and INCOMING_PORT respectively.
Additionally, the sed command used to replace existing persistent configs was not properly escaping the
\in the configuration setting name. This caused invalid qbittorent.conf files to be generated when using either of the above mentioned ENV variables. This change will ensure new deployments or changes to the either variables are updated when the container starts.Once caveat: If you already have an existing qbittorent.conf in your mounted volume, you will either need to edit and add the missing
\in the setting names, or deleted the qbittorent.conf and allow it to be recreated on the next deploy