fix: openvpn/start.sh add condition to prevent appending duplicative name server entries #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple check to prevent writing duplicate entries to
resolv.conf
The issue:
When deploying this image in Kubernetes, using openVPN, in some situations the container would restart without recreating.
This would cause the
start.sh
script to run a second time, and theresolv.conf
would be written to for a second time. Having duplicate entries in theresolv.conf
left the container in a permanent, unrecoverable error state until the pod was manually recreated.Node Specs:
Below is the deployment configuration for anyone looking to recreate this: