Doc, Fix: posthooks of KubernetesEngine initialization

Signed-off-by: Tyler Gu <[email protected]>
MarkintoshZ · Oct 1, 2023 · ee1acd3 · ee1acd3
1 parent c6ff460
commit ee1acd3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/acto/kubernetes_engine/base.py b/acto/kubernetes_engine/base.py
@@ -16,6 +16,12 @@ class KubernetesEngine(ABC):
     @abstractmethod
     def __init__(self, acto_namespace: int,
                  posthooks: List[KubernetesEnginePostHookType] = None) -> None: ...
+    '''Constructor for KubernetesEngine
+    
+    Args:
+        acto_namespace: the namespace of the acto
+        posthooks: a list of posthooks to be executed after the cluster is created
+    '''
 
     @abstractmethod
     def configure_cluster(self, num_nodes: int, version: str):

diff --git a/acto/kubernetes_engine/kind.py b/acto/kubernetes_engine/kind.py
@@ -18,8 +18,7 @@ class Kind(base.KubernetesEngine):
     def __init__(
             self, acto_namespace: int, posthooks: List[base.KubernetesEnginePostHookType] = None):
         self.config_path = os.path.join(CONST.CLUSTER_CONFIG_FOLDER, f'KIND-{acto_namespace}.yaml')
-        if posthooks is not None:
-            self.posthooks = posthooks
+        self.posthooks = posthooks
 
     def configure_cluster(self, num_nodes: int, version: str):
         '''Create config file for kind'''