Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Port is ignored when specified from extra_args #84

Merged
merged 14 commits into from
Mar 10, 2023
Merged

Bug: Port is ignored when specified from extra_args #84

merged 14 commits into from
Mar 10, 2023

Commits on Mar 3, 2023

  1. Save work

    @Harm10
    Harm10 committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    c282c6b View commit details
    Browse the repository at this point in the history

  2. Finished work

    @Harm10
    Harm10 committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    31a3e58 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Rework on port in extra_args

    @robinmatz
    robinmatz committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    a4d5d59 View commit details
    Browse the repository at this point in the history

  2. Test with port from extra_args

    @robinmatz
    robinmatz committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    219e693 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from robinmatz/Open-connection-port-in-args-rework 

    Rework on port in extra_args
    @Harm10
    Harm10 authored Mar 5, 2023
    Configuration menu
    Copy the full SHA
    2cf62a3 View commit details
    Browse the repository at this point in the history

  4. No need to append args

    @robinmatz
    robinmatz committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    a96a95f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Comprimise py3270.py by subclassing

    @robinmatz
    robinmatz committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    06197d5 View commit details
    Browse the repository at this point in the history

  2. Make ExecutableApp abstract

    @robinmatz
    robinmatz committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    043b1aa View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @robinmatz
    robinmatz committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    215b6ee View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Add warning if port is specified as parameter and in extra_args

    @robinmatz
    robinmatz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3a7dfff View commit details
    Browse the repository at this point in the history

  2. Fix pipeline

    @robinmatz
    robinmatz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    baec29f View commit details
    Browse the repository at this point in the history

  3. extra_args defaults to None in constructor

    @robinmatz
    robinmatz committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d6ae825 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from robinmatz/Open-connection-port-in-args-rework 

    Open connection port in args rework
    @Harm10
    Harm10 authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    77f5e7d View commit details
    Browse the repository at this point in the history

  5. Text update

    @Harm10
    Harm10 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    ad01e0f View commit details
    Browse the repository at this point in the history