-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#117 Create Get String Positions Only Before / After keywords #118
#117 Create Get String Positions Only Before / After keywords #118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 97.07% 96.47% -0.60%
==========================================
Files 12 12
Lines 752 767 +15
Branches 170 172 +2
==========================================
+ Hits 730 740 +10
- Misses 18 22 +4
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@robinmatz As I am very busy with other things: what is my dead line? Perhaps I will have time for this coming weekend. |
Hey @Harm10 , no worries, take your time. I'm also trying to do some internal refactoring with this one, which might take a while. |
@robinmatz I am sorry I did not find enough time last weekend. I am trying to set-up a brand new venv for Python 3.11.6 but I still have problems. Now with missing tkinter. So you have to bear with me.................. |
Hello @robinmatz should I merge this one or need to wait for @Harm10 review? |
@robinmatz @samuelpcabral I still have no time to do this properly. I am swamped in work (also in the weekend). I am very sorry. |
Closes #117
@Harm10 , please have a look at the acceptance tests in atest/mainframe.robot. I have implemented the keywords in a way that the specified ypos / xpos in Only Before and Only After are themselves not included. I hope that this is the intended behavior.