Skip to content

Commit

Permalink
Added plugin configuration load in the bin file
Browse files Browse the repository at this point in the history
  • Loading branch information
@Markcial
Markcial committed Mar 3, 2015
1 parent 243a74d commit 8c718e0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bin/psysh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ call_user_func(function() {
}

$config = array();
$config = \Psy\Plugin\Manager::getConfiguration($config);

// Handle --config
if ($configFile = $input->getOption('config')) {
Expand Down

4 comments on commit 8c718e0

@bobthecow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs in Configuration constructor itself. If we do it here, it only works when our entry point into the shell is this file (and not, for example, through Shell::debug)

@Markcial
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, sorry, i was just testing with a package submitted in the packagist. I will redo the files so the configuration is the one responsible about retrieving the configuration that the plugin manager gives.

@bobthecow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. This is looking good, by the way!

@Markcial
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can test it with the recipe detailed here bobthecow#166 (comment), let me know if something is not ok

Please sign in to comment.