Skip to content

Commit

Permalink
Adapt to authentication-tokens 1.4 git:// in pom file
Browse files Browse the repository at this point in the history
jenkinsci/bom#2095 requests the addition of
authentication tokens to the managed set in the plugin bill of materials.

jenkinsci/bom#2189 implements that but shows
that the addition fails because authentication-tokens plugin 1.4 needs
to be pinned for Jenkins 2.375.x and authentication-tokens plugin 1.4
lists its SCM location with a git:// protocol URL instead of an https://
protocol URL.

Use the same workaround that is used for other older plugins.

This can be removed once the 2.375.x line is no longer needed in the
plugin bill of materials.
  • Loading branch information
MarkEWaite committed Jun 17, 2023
1 parent 8041385 commit 9be32f8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/main/java/org/jenkins/tools/test/PluginCompatTester.java
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,13 @@ private static void cloneFromScm(
for (String gitUrl : gitUrls) {
// See: https://github.blog/2021-09-01-improving-git-protocol-security-github/

// TODO pending backport of
// https://github.com/jenkinsci/authentication-tokens-plugin/pull/106
// to 2.375.x
gitUrl = gitUrl.replace(
"git://github.com/jenkinsci/authentication-tokens-plugin",
"https://github.com/jenkinsci/authentication-tokens-plugin");

// TODO pending release of
// https://github.com/jenkinsci/blueocean-display-url-plugin/pull/227
gitUrl = gitUrl.replace(
Expand Down

0 comments on commit 9be32f8

Please sign in to comment.