Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version to v18 #2572

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Conversation

gerteck
Copy link
Contributor

@gerteck gerteck commented Sep 11, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

MarkBind aims to support up to the last maintainence lts release, which is Node.js 18 up to Apr 2025.

This PR seeks to upgrade Node.js to Node 18.

  • Relevant MB documentation on Node.js migration
  • Previous upgrading Node 14 -> 16 PR

Addresses and Fixes #2541

Anything you'd like to highlight/discuss:

Before the version update, check that

  • any deprecated syntax to be refactored
  • all user-facing functionalities are working
  • no issues with the development setup
  • update related GitHub Actions and workflows
    • Test updated Actions
  • docs are updated
  • Deployment to Netlify/other platforms is ok
    • Netlify (PRs 1, 2 opened for netlify quickstart repos to update node version number)
    • GH-Pages
  • Deployment via CI platforms is ok
  • Update netlify.toml

Related PRs:

Related Changes

Other:
Node.js Changelogs

Predecessor Closed PR

Thanks to @tlylt for making the new release, have been able to test the various CI platforms with success.

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Upgrade Node.js to v18


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@gerteck gerteck mentioned this pull request Sep 11, 2024
30 tasks
@tlylt
Copy link
Contributor

tlylt commented Sep 11, 2024

Thanks @gerteck! Will take a look over the weekend

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlylt tlylt merged commit 6c14f5a into MarkBind:master Sep 21, 2024
8 checks passed
@github-actions github-actions bot added the r.Major Version resolver: increment by 1.0.0 label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Major Version resolver: increment by 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Node version to LTS Document: Node LTS (v20) and python 3.12 does not work on MarkBind install
2 participants