Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use node 16 #2233

Merged
merged 13 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,14 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- name: Install Graphviz
uses: tlylt/install-graphviz@v1
- name: Install Java
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'
- run: npm i -g [email protected]
- run: npm run setup
- run: npm run test
deploy-docs:
Expand All @@ -45,15 +44,14 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- name: Install Graphviz
uses: tlylt/install-graphviz@v1
- name: Install Java
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'
- run: npm i -g [email protected]
- run: npm run setup
- name: Deploy DG on any commit to master, to markbind.org/devdocs
run: >-
Expand Down
4 changes: 2 additions & 2 deletions docs/_markbind/variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<variable name="icon_info">:fas-info-circle:</variable>
<variable name="icon_ticked">:far-check-square:</variable>

<variable name="node_version_number">14</variable>
<variable name="node_dev_version_number">14.17.0</variable>
<variable name="node_version_number">16</variable>
<variable name="node_dev_version_number">16.19.1</variable>
<variable name="node_version"><tooltip content="MarkBind aims to support up to the last maintenance lts release as outlined [here](https://nodejs.org/en/about/releases/)">v{{ node_version_number }}</tooltip></variable>
<variable name="node_dev_version"><tooltip content="MarkBind aims to support up to the last maintenance lts release as outlined [here](https://nodejs.org/en/about/releases/)">v{{ node_dev_version_number }}</tooltip></variable>
<variable name="link_live_preview">[live preview](glossary.html#live-preview)</variable>
Expand Down
2 changes: 1 addition & 1 deletion docs/devGuide/development/settingUp.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This page explains how to set up your development environment to start contribut
## Prerequisites

1. **Node.js** ({{ node_dev_version }} or higher) with<br>
**npm** <tooltip content="You may need to upgrade the default npm that is included with Node.js v14 installation">v7</tooltip> or higher
**npm** <tooltip content="You may need to upgrade the default npm that is included with Node.js v16 installation">v8</tooltip> or higher
tlylt marked this conversation as resolved.
Show resolved Hide resolved

1. **Java** 8 or later, and<br>
**Graphviz** v2.38 or later<br>
Expand Down
10 changes: 5 additions & 5 deletions docs/userGuide/deployingTheSite.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- run: npm i -g markbind-cli
- run: markbind deploy --ci
```
Expand Down Expand Up @@ -307,8 +307,8 @@ Commit and push `appveyor.yml` to your GitHub repository. Thereafter, AppVeyor C
steps:
- checkout
- node/install:
node-version: "14"
npm-version: "7"
node-version: "16"
npm-version: "8"
install-yarn: false
- run: node --version
- run: npm i -g markbind-cli
Expand Down Expand Up @@ -427,7 +427,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
- name: Build MarkBind website
run: |
npm install -g markbind-cli
Expand Down Expand Up @@ -497,7 +497,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
- name: Build PR preview url
id: pr-url
run: |
Expand Down