-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give an easy syntax to center-align #1657
Give an easy syntax to center-align #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @riyadh-h :)
Generally looks good. You might want to update the user guide (maybe under this section) to include the new feature.
One thing to note: you can ignore the changes of the .png
files after running npm run updatetest
. It is an open issue #1130.
@jonahtanjz my pleasure, and thanks for the feedback! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riyadh-h :)
LGTM 👍
This reverts commit eae4782.
This reverts commit 04943a7.
What is the purpose of this pull request?
Resolves #900
Overview of changes:
MarkBind can now process text to be center-aligned using the syntax of markdown-it-center-text.
Anything you'd like to highlight / discuss:
text-center
class instead.Testing instructions:
n/a
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️