Skip to content

Commit

Permalink
Update Node version to v20
Browse files Browse the repository at this point in the history
  • Loading branch information
gerteck committed Aug 18, 2024
1 parent 70ba5e5 commit ccf9b9c
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 23 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- name: Install Graphviz
uses: tlylt/install-graphviz@v1
- name: Install Java
Expand All @@ -48,7 +48,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- name: Install Graphviz
uses: tlylt/install-graphviz@v1
- name: Install Java
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- name: Install Graphviz
uses: tlylt/install-graphviz@v1
- name: Install Java
Expand Down
4 changes: 2 additions & 2 deletions docs/_markbind/variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<variable name="icon_info">:fas-info-circle:</variable>
<variable name="icon_ticked">:far-check-square:</variable>

<variable name="node_version_number">16</variable>
<variable name="node_dev_version_number">16.19.1</variable>
<variable name="node_version_number">20</variable>
<variable name="node_dev_version_number">20.16.0</variable>
<variable name="node_version"><tooltip content="MarkBind aims to support up to the last maintenance lts release as outlined [here](https://nodejs.org/en/about/releases/)">v{{ node_version_number }}</tooltip></variable>
<variable name="node_dev_version"><tooltip content="MarkBind aims to support up to the last maintenance lts release as outlined [here](https://nodejs.org/en/about/releases/)">v{{ node_dev_version_number }}</tooltip></variable>
<variable name="graphviz_version_number">2.38</variable>
Expand Down
6 changes: 1 addition & 5 deletions docs/devGuide/development/settingUp.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This page explains how to set up your development environment to start contribut
## Prerequisites

1. **Node.js** ({{ node_dev_version }} or higher) with<br>
**npm** v8 or higher
**npm** v10 or higher

1. **Java** 8 or higher, and<br>
**Graphviz** ({{ graphviz_version }} or higher, _installation is optional on Windows_) <br>
Expand All @@ -32,10 +32,6 @@ This page explains how to set up your development environment to start contribut
* `dot -V` (for Graphviz - optional on Windows)
* `python3 -V`

<box type="warning" seamless>

With Node LTS (v20), the python used has updated to 3.12, and [you may get an error](https://github.com/MarkBind/markbind/issues/2496). You can solve this issue by installing setuptools or deprecating the versions used.
</box>
<box type="tip" seamless>

We recommend the **WebStorm IDE** or **VS Code** for working with MarkBind code.
Expand Down
14 changes: 7 additions & 7 deletions docs/userGuide/deployingTheSite.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- run: npm i -g markbind-cli
- run: markbind deploy --ci
```
Expand Down Expand Up @@ -201,7 +201,7 @@ Since May 2018, Travis CI has been [undergoing migration to `travis-ci.com`](htt
```yml
language: node_js
node_js:
- 16
- 20
install:
- npm i -g markbind-cli
script: markbind build
Expand Down Expand Up @@ -269,7 +269,7 @@ The `repo` value can be changed to your specific repository as desired.

```yml
environment:
nodejs_version: '16'
nodejs_version: 20'
branches:
only:
Expand Down Expand Up @@ -316,8 +316,8 @@ Commit and push `appveyor.yml` to your GitHub repository. Thereafter, AppVeyor C
steps:
- checkout
- node/install:
node-version: "16"
npm-version: "8"
node-version: "20"
npm-version: "10"
install-yarn: false
- run: node --version
- run: npm i -g markbind-cli
Expand Down Expand Up @@ -436,7 +436,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
- name: Build MarkBind website
run: |
npm install -g markbind-cli
Expand Down Expand Up @@ -506,7 +506,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
- name: Build PR preview url
id: pr-url
run: |
Expand Down
5 changes: 0 additions & 5 deletions docs/userGuide/gettingStarted.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
%%{{ icon_ticked }}%% [Node.js](https://nodejs.org) {{ node_version }} or higher installed
</div>

<box type="warning" seamless>

With Node LTS (v20), the python used has updated to 3.12, and [you may get an error](https://github.com/MarkBind/markbind/issues/2496). You can solve this issue by installing setuptools or deprecating the versions used.
</box>

There are a few ways to install MarkBind, select one that is most suitable for your use case. If you are unsure, we recommend using the first method.

## Method 1: Install MarkBind globally with npm
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build]
command = "npm run deploy:netlify"
environment = { NODE_VERSION = "16.19.1"}
environment = { NODE_VERSION = "20.16.0"}

0 comments on commit ccf9b9c

Please sign in to comment.