-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update markbind-action to enhance existing features #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, especially on the recipes.
Formatting wise, should we enclose workflow variables with double backticks for clarity? (e.g. 'gh-pages'
) Not a huge issue though, if the current looks nicer.
Just a few nits otherwise, mostly on the README:
Co-authored-by: Ang Ze Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PR deployments (via Surge), the deployment will not be automatically deleted. This may be possible but the user will need to create another action to trigger the deletion on PR merge/close following this instruction. I guess I can create that as a reusable workflow and link the usage here so that users can choose to include that additional step if needed.
Sounds good, let's put up an issue for tracking. (if not attempting anytime soon)
Last few nits:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @tlylt!
Overall it looks good 👍 Just one suggestion :)
@ang-zeyu @jonahtanjz Thanks for checking! I think I have updated all the required stuff (let me know if there are any more issues). For the release plan, according to this guide for Action release management, I think the steps will be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Let's wait for @ang-zeyu to approve as well :)
Lgtm 👍 Thanks for linking the guide as well! |
Seems like there's a regression possibly to some updates that I did in this PR such that the |
Sorry for the delay. I retested the three cases of baseUrl input and they all seem to work now. I think we are good to proceed with
|
@tlylt Do you have write access to do the tagging and release? Might also want to include a short commit message in the PR description :) |
I have added a commit message. I think I may not have the right to do so (I also don't think I can merge this PR). |
@tlylt you should have permissions now : ) |
Details of this PR has been posted & discussed in the main repo here.
Proposed commit message:
Update markbind-action to enhance existing features
The prerelease markbind-action has certain limitations such
as cannot specify the version of MarkBind to build files or
prevent force-pushing when updating the gh-pages branch.
Let's update it to a composite action and expand on the
existing functionalities to make this action more useful.
New configurations have been included to allow for flexibility
and support more use cases.
Using a composite action also makes it easier to maintain and
reuse existing actions.