Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-35472 Server crash in ha_storage_put_memlim upon reading from INNODB_LOCKS #3649

Open
wants to merge 1 commit into
base: 10.6
Choose a base branch
from

Conversation

dr-m
Copy link
Contributor

@dr-m dr-m commented Nov 21, 2024

  • The Jira issue number for this PR is: MDEV-35472

Description

ha_storage_put_memlim(): Initialize node->next in order to avoid a crash on a subsequent invocation, due to dereferencing an uninitialized pointer.

This fixes a regression that had been introduced in #3584 (MDEV-35189).

Release Notes

Because the bug is being fixed in the same releases that introduce it, no mention is needed.

How can this PR be tested?

Apparently, this subsystem is badly covered by existing regression tests. It would be challenging to test this, because there is some rate-limiting of updates of the cache. This was tested with a small stress test using cmake -DWITH_ASAN=ON.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

…NODB_LOCKS

ha_storage_put_memlim(): Initialize node->next in order to avoid a
crash on a subsequent invocation, due to dereferencing an uninitialized
pointer.

This fixes a regression that had been introduced in
commit ccb6cd8 (MDEV-35189).
@dr-m dr-m self-assigned this Nov 21, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants