Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable replication start on initialization #615

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Disable replication start on initialization #615

merged 2 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. MDEV-34943 Disable replication start on initialization 

    START REPLIA was issued during initializing which mean that
even before /docker-entrypoint/initdb.d there was initializtion
going on.

Entrypoints that needed data initialzation didn't complete with
this nicely. Also if there wasn't any initialization there
would be little time for the replication to acheive anything
before being shutdown ready for the final start.

Moved --skip-slave-start to the default docker_temp_server_start
implementation.

Technically this is a compaibility break that is likely to be
of significants if:
* /docker-entrypoint/initdb.d contains a script waiting
  for replication to catch up.

The recitifcation to the previous behaviour is:
/docker-entrypoint/initdb.d contains a SQL to START REPLICA.
Recommend also having another script that is:

until healthcheck.sh --replication_io \
                     --replication_sql \
                     --replication_seconds_behind_master=0 \
                     --replication
                     --no-connect;
do
  sleep 1
done

Closes MariaDB#614
    @grooverdan
    grooverdan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fe4d1ee View commit details
    Browse the repository at this point in the history

  2. healthcheck.sh add --no-connect option 

    There is an implicit --connect option in healthcheck
so that a normal use can be sure MariaDB is running
on a tcp socket.

There is a case in /docker-entrypoint-initdb.d where
its desirable to perform healthchecks for components
without a --connect. In this case, use --no-connect
in the healthcheck to avoid an implicit --connect test.
    @grooverdan
    grooverdan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    90a7e44 View commit details
    Browse the repository at this point in the history