Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarball checksum check - use sha256sum -c #510

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

There where some failures. Might be a divering implemnation on output but eitherway, sha256sum can check directly without needed to do the comparision in bash.

Adjust path so the tarball can be found by sha256sum.

There where some failures. Might be a divering implemnation on
output but eitherway, sha256sum can check directly without needed
to do the comparision in bash.

Adjust path so the tarball can be found by sha256sum.
Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change affects all builders , looks ok but after merge needs a regression test on DEV .
I suggest printing checksum's in standard output so we can track at runtime what is really happening.

@fauust
Copy link
Collaborator

fauust commented Jul 25, 2024

Looks OK but yes, it needs testing before merge in prod since it will impact every builder.

Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition Daniel,
after this merge let's schedule a full run on Dev and watch closely how all builders behave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants