Skip to content

Commit

Permalink
ruff rule F601 - Dictionary key literal 'use_composition' repeated (r…
Browse files Browse the repository at this point in the history
…os-navigation#4293)

% `ruff check`
```
Error: nav2_system_tests/src/system/test_wrong_init_pose_launch.py:117:21: F601 Dictionary key literal `'use_composition'` repeated
```
% ` ruff rule F601`
# multi-value-repeated-key-literal (F601)

Derived from the **Pyflakes** linter.

Fix is sometimes available.

## What it does
Checks for dictionary literals that associate multiple values with the
same key.

## Why is this bad?
Dictionary keys should be unique. If a key is associated with multiple values,
the earlier values will be overwritten. Including multiple values for the
same key in a dictionary literal is likely a mistake.

## Example
```python
foo = {
    "bar": 1,
    "baz": 2,
    "baz": 3,
}
foo["baz"]  # 3
```

Use instead:
```python
foo = {
    "bar": 1,
    "baz": 2,
}
foo["baz"]  # 2
```

## References
- [Python documentation: Dictionaries](https://docs.python.org/3/tutorial/datastructures.html#dictionaries)

Signed-off-by: Christian Clauss <[email protected]>
  • Loading branch information
cclauss authored and Marc-Morcos committed Jul 4, 2024
1 parent cea220b commit 7c60d0c
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ def generate_launch_description():
'bt_xml_file': bt_navigator_xml,
'use_composition': 'False',
'autostart': 'True',
'use_composition': 'False',
}.items(),
),
]
Expand Down

0 comments on commit 7c60d0c

Please sign in to comment.