Use arrays for center and bounds in tilejson #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4 This does not validate that the parameter in the Mapnik XML is valid, but if it is valid, it will result in a valid TileJSON.
| @@ -2,7 +2,8 @@ | |||
| srs="+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +no_defs +over"> | |||
| <Parameters> | |||
| <Parameter name="metatile">1</Parameter> | |||
| <Parameter name="center">-75.6038,40.0799,11</Parameter> | |||
| <Parameter name="center">-75,40,11</Parameter> | |||
There was a problem hiding this comment.
Is there any significance to making the center values all integers?
There was a problem hiding this comment.
No - just a shorter output in the tests
| @@ -216,7 +219,11 @@ std::string make_tilejson(const mapnik::Map &map, | |||
|
|
|||
| for (auto const &row : params) { | |||
| out << "\"" << row.first << "\":"; | |||
| mapnik::util::apply_visitor(json_converter(out), row.second); | |||
| if (array_keys.count(row.first) > 0) { | |||
There was a problem hiding this comment.
Is this better than array_keys.find(row.first) == array_keys.end?
There was a problem hiding this comment.
It's effectively the same (well, with !=), but I think it's more readable.
|
Looks good, |
pnorman
added a commit
that referenced
this pull request
Dec 11, 2014
Use arrays for center and bounds in tilejson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This does not validate that the parameter in the Mapnik XML is valid,
but if it is valid, it will result in a valid TileJSON.
cc @zerebubuth