Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing new job init- merge tiles tasks creation(MAPCO-4348) #5

Merged
merged 20 commits into from
Sep 12, 2024

Conversation

almog8k
Copy link
Collaborator

@almog8k almog8k commented Aug 22, 2024

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Further information:
Implementing the handleJobInit for NewJobHandler:

  1. Build merge tasks and push them to the JobMabnager Queue.
  2. Finish Ingestion-New init task.
  3. Currently for every error occurred the init task sets to status- Failed

@CL-SHLOMIKONCHA
Copy link
Contributor

add maxAttempts configuration for tasks and validate it before processing jobs

@CL-SHLOMIKONCHA
Copy link
Contributor

Go through all logs that print the entire job (info level) and change it to 'debug' - add info logs with the specific important fields like: 'jobId', 'taskId' etc...

src/common/interfaces.ts Outdated Show resolved Hide resolved
src/common/interfaces.ts Outdated Show resolved Hide resolved
src/common/interfaces.ts Outdated Show resolved Hide resolved
config/default.json Outdated Show resolved Hide resolved
config/default.json Outdated Show resolved Hide resolved
src/job/models/newJobHandler.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
tests/unit/mocks/configMock.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work,
please mind comments + add test for getTask()

edit: you have this test (getJobAndTaskResponse tests) to cover it so its unnecessary.
image

src/common/interfaces.ts Show resolved Hide resolved
src/job/models/jobProcessor.ts Outdated Show resolved Hide resolved
src/job/models/jobProcessor.ts Outdated Show resolved Hide resolved
src/job/models/newJobHandler.ts Outdated Show resolved Hide resolved
src/job/models/newJobHandler.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
src/task/models/mergeTilesTaskBuilder.ts Outdated Show resolved Hide resolved
tests/unit/job/jobProcessor/JobProcessor.spec.ts Outdated Show resolved Hide resolved
tests/unit/job/jobProcessor/JobProcessor.spec.ts Outdated Show resolved Hide resolved
@CL-SHLOMIKONCHA
Copy link
Contributor

TODO: if there is no support job handler for the dequeued job type, reject the task as unrecoverable

src/job/models/jobProcessor.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@almog8k almog8k merged commit 418c449 into master Sep 12, 2024
8 checks passed
@almog8k almog8k deleted the handleJobInit branch September 12, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants