Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: aggregation implementation #32

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Conversation

almog8k
Copy link
Collaborator

@almog8k almog8k commented Nov 28, 2024

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore
Refactor

Further information:
Changing the parameter that we are sending to PolygonpartsManager when making aggregation request:
prev: /aggregation/catlogId
new:/aggregation/polygonPartsEntityName

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA self-requested a review December 1, 2024 07:13
src/utils/zod/schemas/jobParametersSchema.ts Outdated Show resolved Hide resolved
src/httpClients/polygonPartsMangerClient.ts Show resolved Hide resolved
src/httpClients/catalogClient.ts Outdated Show resolved Hide resolved
src/utils/zod/schemas/jobParametersSchema.ts Outdated Show resolved Hide resolved
tests/unit/httpClients/catalogCLientSetup.ts Outdated Show resolved Hide resolved
src/utils/zod/schemas/jobParametersSchema.ts Outdated Show resolved Hide resolved
@CL-SHLOMIKONCHA CL-SHLOMIKONCHA merged commit dc82f0b into master Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants