feat: polling loop using generator, manging job flow with jobHandler (MAPCO-4439) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafMasa
reviewed
Jul 23, 2024
src/services/jobProcessor.ts
Outdated
| }; | ||
| } | ||
|
|
||
| public async consumeAndProcess(): Promise<void> { |
There was a problem hiding this comment.
is this function is called each interval? how?
CL-SHLOMIKONCHA
requested changes
Jul 28, 2024
There was a problem hiding this comment.
Good job! nice tests. consider add ingestion test with nock:
exmaple:
https://github.com/MapColonies/ingestion-trigger/blob/52f2212151c231f3fe48ad2c98e2b3e0067aea70/tests/integration/ingestion/ingestion.spec.ts#L565
CL-SHLOMIKONCHA
requested changes
Jul 29, 2024
CL-SHLOMIKONCHA
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further information:
Added polling loop using generator to dequeue init task with one of the job_types we support ["Ingestion_New", "Ingestion_Update", "Ingestion_Swap_Update"].
And get the relevant job and decide what's the job flow by his type.