Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ingestion new finalize (MAPCO-4785) #15

Merged
merged 6 commits into from
Oct 14, 2024
Merged

feat: Ingestion new finalize (MAPCO-4785) #15

merged 6 commits into from
Oct 14, 2024

Conversation

almog8k
Copy link
Collaborator

@almog8k almog8k commented Oct 10, 2024

Question Answer
Bug fix ✖
New feature ✔
Breaking change ✖
Deprecations ✖
Documentation ✖
Tests added ✔
Chore ✖

Further information:
Add Ingestion_New finalize task handling:

  • publishing to mapproxyApi
  • publishing to geoserver
  • publishing to catalog

CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Oct 13, 2024
View reviewed changes
helm/templates/configmap.yaml Outdated Show resolved Hide resolved
helm/templates/configmap.yaml Outdated Show resolved Hide resolved
helm/templates/configmap.yaml Outdated Show resolved Hide resolved
helm/templates/configmap.yaml Outdated Show resolved Hide resolved
src/common/interfaces.ts Outdated Show resolved Hide resolved
src/job/models/newJobHandler.ts Show resolved Hide resolved
src/httpClients/geoserverClient.ts Outdated Show resolved Hide resolved
CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the ca to global scope

@almog8k almog8k merged commit 1296b9b into master Oct 14, 2024
8 checks passed
@almog8k almog8k deleted the ingestion-new-finalize branch October 14, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA CL-SHLOMIKONCHA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almog8k @CL-SHLOMIKONCHA