Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement changeset API of API v0.6 #15

Merged
merged 3 commits into from
Dec 3, 2020
Merged

implement changeset API of API v0.6 #15

merged 3 commits into from
Dec 3, 2020

Conversation

galta95
Copy link
Contributor

@galta95 galta95 commented Dec 3, 2020

closes #2 #3 #4 #10

* feat(/api/0.6/changeset/create): new rout

* test(/api/0.6/changeset/create): unit test

* feat(eslint): added semicolon role

* style(lint): missing semicolons and change file name

* build(npm): added nock

* style(lint): added semicolon

* refactor(/api/0.6/changeset/create):  refactor requested changes

* fix(/api/0.6/changeset/create): move out the res parsing from try & catch

* refactor(all): use generics

* refactor(/api/0.6/changeset/create): error handler

* ci(tests): added unit tests and lint workflows (#11)

* ci(tests): added unit tets

* fix(github- workflows): split to two different .yml files for each job category

* refactor(.github/workflows): added linting to tests directories
* feat(apiv06): new route /api/0.6/changeset/#id/close

* style(prettier): format all documents

* refactor(apiv06): export api res messages to constants

* style(prettier): added print width to 150

* style(rename-file): error-handler to errors

* style(constants): rename constants
* feat(apiv6): implemented upload Changeset

* refactor(apiv06): switch case in upload route  instead of if else
@galta95 galta95 requested a review from syncush December 3, 2020 14:50
@syncush syncush changed the title Apiv6 implement changeset API of API v0.6 Dec 3, 2020
@syncush syncush merged commit cfed1cb into master Dec 3, 2020
@syncush syncush deleted the apiv6 branch December 3, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT /api/0.6/changeset/create
2 participants