Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metadata models): update layer metadata models #19

Merged
merged 11 commits into from
Jan 31, 2021
Merged

feat(metadata models): update layer metadata models #19

merged 11 commits into from
Jan 31, 2021

Conversation

shimoncohen
Copy link
Contributor

No description provided.

@shimoncohen shimoncohen added the enhancement New feature or request label Jan 26, 2021
@shimoncohen shimoncohen added this to the sprint 19_01_21-01_02_21 milestone Jan 26, 2021
@shimoncohen shimoncohen self-assigned this Jan 26, 2021
cl-shaharshavit-rnd
cl-shaharshavit-rnd suggested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@cl-shaharshavit-rnd cl-shaharshavit-rnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some models are missing from typescript types as they are not defined as "base"

@shimoncohen
feat(metadata models): update layer metadata models
f82e0a5
@shimoncohen
Merge branch 'update-layer-metadata-models' of https://github.com/Map…
26d0c91 
…Colonies/mc-models into update-layer-metadata-models
@shimoncohen
Merge branch 'update-layer-metadata-models' of https://github.com/Map…
db4d943 
…Colonies/mc-models into update-layer-metadata-models
@shimoncohen
Merge branch 'update-layer-metadata-models' of https://github.com/Map…
b512133 
…Colonies/mc-models into update-layer-metadata-models
@shimoncohen
Merge branch 'update-layer-metadata-models' of https://github.com/Map…
528ec38 
…Colonies/mc-models into update-layer-metadata-models
@shimoncohen
Merge branch 'update-layer-metadata-models' of https://github.com/Map…
cfdaec5 
…Colonies/mc-models into update-layer-metadata-models
cl-shaharshavit-rnd
cl-shaharshavit-rnd suggested changes Jan 31, 2021
View reviewed changes
Schema/yaml/geojson.yaml Outdated Show resolved Hide resolved
Schema/yaml/layerMetadata.yaml Outdated Show resolved Hide resolved
asafMasa
asafMasa requested changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Schema/models/LayerMetadata-StatusFields.d.ts Outdated Show resolved Hide resolved
@shimoncohen shimoncohen merged commit 95b06d1 into master Jan 31, 2021
@shimoncohen shimoncohen deleted the update-layer-metadata-models branch January 31, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl-shaharshavit-rnd cl-shaharshavit-rnd cl-shaharshavit-rnd approved these changes

@asafMasa asafMasa asafMasa approved these changes

Assignees

@shimoncohen shimoncohen

Labels
enhancement New feature or request
Projects
None yet
Milestone
sprint 19_01_21-01_02_21
Development

Successfully merging this pull request may close these issues.
3 participants
@shimoncohen @asafMasa @cl-shaharshavit-rnd