feat(db): make percentage column NOT NULL and add DEFAULT 0
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - The `percentage` column is now NOT NULL. This will cause failures in any code attempting to insert or update rows with a null value for `percentage`. - Existing data has been migrated to set null values to 0. - A DEFAULT constraint of 0 has been added, altering the behavior of inserts when `percentage` is not specified. Applications relying on nullable `percentage` values or handling null explicitly must be updated to comply with these changes.
asafMasa
approved these changes
Dec 22, 2024
CL-SHLOMIKONCHA
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
percentagecolumn is now NOT NULL. This will cause failures in any code attempting to insert or update rows with a null value forpercentage.percentageis not specified.Applications relying on nullable
percentagevalues or handling null explicitly must be updated to comply with these changes.