feat: added option for releaseInactive to not raise task attempts (MAPCO-5466) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CL-SHLOMIKONCHA
requested changes
Nov 24, 2024
CL-SHLOMIKONCHA
approved these changes
Nov 24, 2024
netanelC
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this feature to handle task liberator's updateTime release better. Task liberator releases "lost" tasks that were pulled but never had a heartbeat. In the current version, Job manager would release the task and raise the task's attempts by one. This way, attempts are raised without a worker working on the task, and by the time a worker actually works on that task, the attempts reach its limits. This PR adds an option through an optional query param to release the task without raising the number of attempts. If the "shouldRaiseAttempts" param is not provided, the default behavior will increase the attempts. This way it doesn't break anything and past requests should still work. A following task liberator PR will come.
A video of a local test of the expected behaviour:
job-manager.webm