Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding traces support (MAPCO-3893) #36

Merged
merged 8 commits into from
Feb 26, 2024
Merged

feat: adding traces support (MAPCO-3893) #36

merged 8 commits into from
Feb 26, 2024

Conversation

almog8k
Copy link
Contributor

@almog8k almog8k commented Feb 22, 2024

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Further information:
Adding traces support.

Copy link

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (decoration principles are nice and clear)

@asafMasa asafMasa changed the base branch from master to dev February 25, 2024 08:50
@asafMasa asafMasa changed the base branch from dev to master February 25, 2024 08:50
@asafMasa asafMasa changed the title Adding traces support(MAPCO-3893) feat: adding traces support(MAPCO-3893) Feb 25, 2024
@asafMasa asafMasa changed the title feat: adding traces support(MAPCO-3893) feat: adding traces support (MAPCO-3893) Feb 25, 2024
Copy link

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@almog8k almog8k merged commit 2e8920d into master Feb 26, 2024
9 checks passed
@almog8k almog8k deleted the adding-traces branch February 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants