Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: auto ingress host #35

Merged
merged 3 commits into from
Feb 25, 2024
Merged

chore: auto ingress host #35

merged 3 commits into from
Feb 25, 2024

Conversation

almog8k
Copy link
Contributor

@almog8k almog8k commented Feb 20, 2024

Question Answer
Bug fix ✖
New feature ✖
Breaking change ✖
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✔
  1. Adding Ingress.domain under global to values.yaml
  2. changing host name value based on releaseName-chartName-IngressDomain

alebinson
alebinson approved these changes Feb 25, 2024
View reviewed changes
Copy link

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@asafMasa asafMasa merged commit 34b20c3 into master Feb 25, 2024
9 checks passed
@asafMasa asafMasa deleted the ingress-host branch February 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netanelC netanelC netanelC approved these changes

@alebinson alebinson alebinson approved these changes

@asafMasa asafMasa asafMasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@almog8k @asafMasa @alebinson @netanelC